Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #81

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and make associated project configuration changes.

Enhancements:

  • Update default branch to "main".
  • Update issue templates.

Build:

  • Update Node to v22.

CI:

  • Update CI to test on Node 20 and 22.

Deployment:

  • Add workflow to publish demo on pull requests to main.

Documentation:

  • Update documentation to reflect changes to Node version and branching strategy.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:43
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the Auro project to use Node.js v22 and introduces some changes to the contribution guidelines.

State diagram for branch protection rules

stateDiagram-v2
    [*] --> PR_Created
    PR_Created --> Tests
    state Tests {
        Node20x: Test on Node 20.x
        Node22x: Test on Node 22.x
        CLA: License/CLA check
    }
    Tests --> PR_Review: All tests pass
    PR_Review --> [*]: Approved and merged to main
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version from 18.x and 20.x to 20.x and 22.x in CI workflows.
  • Updated Node.js version in package.json to reflect the new supported versions.
  • Updated CodeQL workflow to use Node.js v22
.github/workflows/testPublish.yml
package.json
.github/workflows/codeql.yml
Updated contribution guidelines
  • Updated the Innersourcing Flow Guide link.
  • Clarified the language around feature requests.
  • Updated the issue submission process.
  • Clarified the bug reporting guidelines.
  • Updated the branch naming convention to use "main" instead of "master".
  • Updated the rebase instructions to use "main" instead of "master".
  • Added information about Conventional Commits and commit message formatting.
  • Added information about commit message prefixes and their meanings.
  • Added a section on Git commit messages and their format.
  • Added a section on the pull request service level agreement.
.github/CONTRIBUTING.md
Updated repository settings
  • Removed the repository description.
  • Updated the list of topics.
  • Updated the default branch to "main".
  • Added team permissions for Auro team and non-Auro team with write access.
.github/settings.yml
Updated issue templates
  • Added exit criteria section to feature request and general support issue templates.
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Updated workflows and other files
  • Updated CODEOWNERS file.
  • Updated stale.yml configuration.
  • Updated pull request template.
  • Updated code of conduct.
  • Updated package-lock.json.
  • Added publishDemo.yml workflow.
.github/CODEOWNERS
.github/stale.yml
.github/PULL_REQUEST_TEMPLATE.md
.github/CODE_OF_CONDUCT.md
package-lock.json
.github/workflows/publishDemo.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #80

@jason-capsule42 jason-capsule42 changed the base branch from master to main December 22, 2024 18:23
@jason-capsule42 jason-capsule42 force-pushed the migration/package-update/node-v22 branch from f38d088 to dc3d6b1 Compare December 22, 2024 18:34
Copy link

Surge demo deployment failed! 😭

@jason-capsule42 jason-capsule42 merged commit 643ada9 into main Dec 22, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-v22 branch December 22, 2024 18:37
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
3 participants