Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #87

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Build:

  • Update the build step to include PostCSS and update Node to v22

CI:

  • Update CI to test on Node 20 and 22

Documentation:

  • Revise contributing guidelines, update issue templates, and add settings YAML file.

@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js version 22 and introduces several improvements to the contributing guidelines and repository settings.

State diagram for PR workflow changes

stateDiagram-v2
    [*] --> IssueSubmitted
    IssueSubmitted --> UnderReview: Within 48h
    UnderReview --> Abandoned: No response
    UnderReview --> Approved: Team consultation
    Approved --> PullRequest: Start work
    PullRequest --> ReviewProcess
    ReviewProcess --> Merged: If solicited (24h)
    ReviewProcess --> ExtendedReview: If unsolicited (72h)
    ExtendedReview --> Merged
    note right of ExtendedReview: Additional resources
    note right of ReviewProcess: New SLA process
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version in test and publish workflow
  • Updated Node.js version in package.json
  • Regenerated package-lock.json
  • Updated Node.js version in CodeQL workflow
  • Updated Node.js version in repository settings
.github/workflows/testPublish.yml
package.json
package-lock.json
.github/workflows/codeql.yml
.github/settings.yml
Improved contributing guidelines
  • Added more details and context to the guidelines
  • Clarified the process for submitting issues and pull requests
  • Updated the branch naming convention
  • Added information about rebasing and conventional commits
.github/CONTRIBUTING.md
Updated repository settings
  • Added team permissions for administration and push access
  • Updated status checks for pull requests
.github/settings.yml
Added a workflow to publish a demo
  • Created a new workflow to automatically deploy the demo on pull requests to the main branch
.github/workflows/publishDemo.yml
Added CODEOWNERS file
  • Created a CODEOWNERS file to define code ownership and improve the review process
.github/CODEOWNERS
Updated stale.yml
  • Added more configuration options to the stale.yml file to customize the stale issue and pull request process
.github/stale.yml
Updated other files
  • Updated the pull request template to improve clarity and consistency
  • Updated the code of conduct to reflect current best practices
.github/PULL_REQUEST_TEMPLATE.md
.github/CODE_OF_CONDUCT.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

1 similar comment
Copy link

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #86

@jordanjones243 jordanjones243 force-pushed the migration/package-update/node-v22 branch from e757534 to 2531419 Compare December 20, 2024 22:18
@sun-mota sun-mota requested a review from rmenner December 20, 2024 22:21
@jason-capsule42 jason-capsule42 merged commit 91365f1 into main Dec 22, 2024
6 of 8 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-v22 branch December 22, 2024 18:20
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
4 participants