-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO MIGRATION: Update node to v22 #149
Conversation
Reviewer's Guide by SourceryThis PR updates the Node version used in the project to v22. It modifies the CI workflow, settings, package.json, and package-lock.json files to reflect this change. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- In package.json, the Node.js version specification could be simplified to
"node": "^20 || ^22"
- the.x
suffix is unnecessary when using the caret operator
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -17,7 +17,7 @@ | |||
"main": "index.js", | |||
"license": "Apache-2.0", | |||
"engines": { | |||
"node": "^18 || ^20" | |||
"node": "^20.x || ^22.x " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Simplify Node.js version specification by removing redundant '.x' suffix
The caret (^) operator already handles minor and patch versions. Using '^20 || ^22' would be more idiomatic and achieve the same result.
"node": "^20.x || ^22.x " | |
"node": "^20 || ^22" |
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node.js to v22.x.
Enhancements:
CI: