Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #149

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node.js to v22.x.

Enhancements:

  • Update Node.js version to v20.x || v22.x in package.json and package-lock.json.

CI:

  • Update CI workflows to test against Node.js v22.x and remove Node.js v18.x from the test matrix.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:42
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the Node version used in the project to v22. It modifies the CI workflow, settings, package.json, and package-lock.json files to reflect this change.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Node version in CI workflow
  • Updated the Node version matrix in the test and publish workflow to use Node 20 and 22.
  • Updated the Node version used in the setup-node action to 22.
.github/workflows/testPublish.yml
Updated required status checks
  • Updated the required status checks to include Node 20 and 22, removing the check for Node 18.
.github/settings.yml
Updated Node engine version in package.json
  • Updated the Node engine version to specify compatibility with Node 20 and 22.
package.json
Regenerated package-lock.json
  • Updated the package-lock.json file to reflect the changes in package.json and the updated Node version.
package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • In package.json, the Node.js version specification could be simplified to "node": "^20 || ^22" - the .x suffix is unnecessary when using the caret operator
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -17,7 +17,7 @@
"main": "index.js",
"license": "Apache-2.0",
"engines": {
"node": "^18 || ^20"
"node": "^20.x || ^22.x "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Simplify Node.js version specification by removing redundant '.x' suffix

The caret (^) operator already handles minor and patch versions. Using '^20 || ^22' would be more idiomatic and achieve the same result.

Suggested change
"node": "^20.x || ^22.x "
"node": "^20 || ^22"

@jordanjones243 jordanjones243 merged commit 9b23998 into main Dec 20, 2024
6 of 7 checks passed
@jordanjones243 jordanjones243 deleted the migration/package-update/node-v22 branch December 20, 2024 22:04
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
3 participants