Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #44

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and migrate to Auro library v3.

Enhancements:

  • Remove graphiteWidth option for performance reasons.
  • Update repository settings to remove description and update topics.
  • Update team permissions to grant admin access to auro-team and push access to nonauroteamwriteaccess.
  • Update contributing guidelines with information about conventional commits and rebasing.
  • Add a workflow to deploy a demo on pull requests to the main branch.

Build:

  • Update Node version to v22 in the project configuration.

CI:

  • Update CI workflows to test against Node 20 and 22.

Tests:

  • Update test matrix in CI to include Node version 22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:46
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js v22 and introduces Conventional Commits.

Sequence diagram for updated PR workflow with Conventional Commits

sequenceDiagram
    actor Developer
    participant Git
    participant CI

    Developer->>Git: Create feature branch
    Developer->>Git: Make changes
    Developer->>Git: Commit with conventional format<br/>(type(scope): subject)
    Note over Developer,Git: Format: feat/fix/perf(scope): message
    Developer->>Git: Push changes
    Git->>CI: Trigger CI pipeline
    CI->>CI: Run tests on Node v20.x & v22.x
    CI-->>Developer: Return test results
    Note over Developer,CI: Tests must pass on both<br/>Node v20.x and v22.x
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22 in the test and publish workflow.
  • Updated Node.js version to v22 in package.json.
  • Updated the required Node.js version for tests to v22 in the settings file.
.github/workflows/testPublish.yml
package.json
.github/settings.yml
Introduced Conventional Commits
  • Added information about Conventional Commits and commit message formatting to the contributing guidelines.
.github/CONTRIBUTING.md
Added a workflow to publish a demo
  • Created a new workflow to publish a demo upon pull request merge.
.github/workflows/publishDemo.yml
Updated repository settings
  • Removed the repository description.
  • Updated repository topics.
  • Added team access settings.
.github/settings.yml
Updated contributing guidelines
  • Clarified the process for submitting issues and pull requests.
  • Added information about rebasing and maintaining a linear repository history.
  • Removed the requirement to run "npm i" before working on a project.
.github/CONTRIBUTING.md
Updated stale bot configuration
  • Added spacing between configuration options for better readability.
.github/stale.yml
Updated pull request template
  • Removed an unnecessary blank line.
.github/PULL_REQUEST_TEMPLATE.md
Updated CodeQL workflow
  • Removed unnecessary blank lines.
.github/workflows/codeql.yml
Updated code of conduct
  • Added line breaks for better readability.
.github/CODE_OF_CONDUCT.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@sun-mota sun-mota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs #43

@DukeFerdinand DukeFerdinand force-pushed the migration/package-update/node-v22 branch from 44c5218 to 45c46cc Compare December 23, 2024 19:08
@DukeFerdinand
Copy link
Contributor

Merging in without waiting for requirements. Reason: Node 18 is no longer a required action and will be replaced with node 20/22

@DukeFerdinand DukeFerdinand merged commit 9eec344 into main Dec 23, 2024
6 of 7 checks passed
@DukeFerdinand DukeFerdinand deleted the migration/package-update/node-v22 branch December 23, 2024 20:29
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
4 participants