Fix #75

AlexandreDecan · Jan 28, 2023 · a5c2da8 · a5c2da8
1 parent e49898c
commit a5c2da8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,14 +1,15 @@
 # Changelog
 
 
-## 2.3.1 (not yet released)
+## 2.3.1 (2023-01-28)
 
 ### Changed
  - Speed up lookups in `IntervalDict` for non-interval keys.
+ - Speed up `iterate` by no longer creating singleton instances under the hood.
  - Drop official support for Python 3.6.
 
 ### Fixed
- - Infinite recursion in `iterate` with `Interval` subclasses (see [#75](https://github.com/AlexandreDecan/portion/issues/75)).
+ - Infinite recursion when a subclass of an `Interval` is compared using `>` with an `Interval` instance (see [#75](https://github.com/AlexandreDecan/portion/issues/75)).
 
 
 

diff --git a/portion/interval.py b/portion/interval.py
@@ -629,7 +629,13 @@ def __lt__(self, other):
 
     def __gt__(self, other):
         if isinstance(other, Interval):
-            return other < self
+            if self.empty or other.empty:
+                return False
+
+            if self.left == Bound.OPEN or other.right == Bound.OPEN:
+                return self.lower >= other.upper
+            else:
+                return self.lower > other.upper
         else:
             warnings.warn(
                 "Comparing an interval and a value is deprecated. Convert value to singleton first.",

diff --git a/setup.py b/setup.py
@@ -9,7 +9,7 @@
 
 setup(
     name="portion",
-    version="2.3.1-pre1",
+    version="2.3.1",
     license="LGPLv3",
     author="Alexandre Decan",
     url="https://github.com/AlexandreDecan/portion",
@@ -34,7 +34,7 @@
     ],
     keywords="interval operation range math",
     packages=find_packages(include=["portion"]),
-    python_requires="~= 3.6",
+    python_requires="~= 3.7",
     install_requires=[
         "sortedcontainers ~= 2.2",
     ],