-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table and Figure S1 legends #54
Conversation
Click the link below to download the manuscript build as a ZIP file. |
…A-manuscript into sjspielman/s1-legends
Click the link below to download the manuscript build as a ZIP file. |
Click the link below to download the manuscript build as a ZIP file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but we should probably try and figure out the issue with figure 5 being prefixed to the legend.
On that same note, I noticed that all the other ones have Figure X: Figure X. Description
. I think we should make sure that the Figure X
is only written one time in the legend title.
content/100.figure-table-legends.md
Outdated
All remaining columns give the number of libraries (as designated with `(L)`) with the given suspension or additional modality. | ||
|
||
|
||
![**Figure S1. Results from benchmarking `alevin-fry` and `CellRanger` performance.**](https://raw.githubusercontent.com/AlexsLemonade/scpca-paper-figures/main/figures/compiled_figures/pngs/figure_s1.png?sanitize=true){#fig:figs1 width="7in"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is still rendering as Figure 5. I feel like we might want to figure that out before merging this in?
Aha, found answers to supplemental figure numbering - https://github.com/manubot/try-manubot/blob/main/USAGE.md#figures |
Co-authored-by: Ally Hawkins <[email protected]>
Click the link below to download the manuscript build as a ZIP file. |
…s well as guiding comments
Legend titles now working as expected! |
Click the link below to download the manuscript build as a ZIP file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #32
Towards #14
This PR adds the legend for Table S1 and Figure S1. I included the link to display Fig S1 in the document, but not Table S1 b/c it's a table. But, we could add a markdown version of the table directly in here if we want..?
For Figure S1, I am looking for some recommendations to tighten up the wording. I feel it's a little repetitive now. I tried to ameliorate some of that by grouping some text that was similar to either all panels, or all panels B-D, but I think it can maybe be tightened up further. On the other hand, we could go the exact opposite route and not tighten up at all, but "loosen" the text to be more descriptive about each panel on its own terms!