-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for ayab-esp32 #34
Conversation
This adds:
|
If it's a tagged version, you could upload the artifact to the release, otherwise 1 month is probably fine. I think it might be 90 days actually. |
Yea, I was thinking more on it last night, and I think that generating the artifact on each merge to main is good, and then when we actually cut a hardware release (i.e. buy boards) then we can just take the artifact and upload to a release makes sense, at least for all the production files as we should not circulate un-verified files. |
OK, this should work, we just need to create a secret github token with repo access. It will open a PR from ayab-hardware/documentation into main, skipping CI to add the generated PDFs to ayab-hardware/ayab-esp32/pdf/ |
We tend not to keep other auto-generated files, but I think we should probably keep schematic pdfs and gerbers. |
Yes, I set it to only add the PDFs. The "real" production files needed to order are still kept as artifacts so they can be used in a tagged release. |
OH, I misunderstood, the token is generated as part of the action, so it is already pre-verified. So this should be good to go. |
No description provided.