-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter1/homework/4 #798
Open
MostafaA1s
wants to merge
36
commits into
Almantask:Chapter1/Homework/4
Choose a base branch
from
MostafaA1s:Chapter1/Homework/4
base: Chapter1/Homework/4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chapter1/homework/4 #798
MostafaA1s
wants to merge
36
commits into
Almantask:Chapter1/Homework/4
from
MostafaA1s:Chapter1/Homework/4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should provide some sort of step-by-step guide on how to set things up properly.
…/Homework/3-Readme Proper description of the homework 3 task in the README.md file
Console sub to file, invalid input validation, invalid BMI validation
Set console output when it's just faked, better naming
Applied console messaging to file for every test in ctor
Explained if statements and how they can help to clean up the input validation
- Simlpified homework task by removing inconsistencies
Shorter readme for intro. More details in the wiki.
…Sharp-From-Zero-To-Hero into Chapter1/Homework/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re factored for if conditions