fix: Use effective tpf value in LoopRunner (onUpdate) #1298
Conversation
|
|
||
| listOf( | ||
| // run with a given ticks per second (via scheduled service tick) | ||
| LoopRunner(60) { t += it; Thread.sleep(lag) } |
There was a problem hiding this comment.
Please note that this test case doesn't use: LoopRunner { t += it; Thread.sleep(lag) } case.
Mainly, JavaFX will not be affected by the Lag and will process 60 frames anyway.
| runnable(tpf) | ||
| tpf = (now - lastFrameNanos).toDouble() / 1_000_000_000 | ||
|
|
||
| val ticksPerSecond = if (ticksPerSecond < 0) 60 else ticksPerSecond // For JavaFX loops, cap at 60fps too |
There was a problem hiding this comment.
Please note that this is a safety mesure. I was supprised to see that JavaFX was defaulted to 120FPS on a Mac (instead of the 60FPS defined in the JavaFX documentation). In order to make tests "predictable", I had to cap it to 60FPS as each LoopRunner { t += it; Thread.sleep(lag) } test cases were failing by returning 120FPS
|
Hi @AlmasB, I've resolved a bug where pausing would cumulate all tpf while paused. I've adjusted the loop and the tests to reflect that. Sorry for that! |
|
Hi @AlmasB , I've been using this fix for quite a while now. I've since experienced stable FPS. I must say that this change is a game changer for the Engine. The previous LoopRunner was causing "fake" lag (highly noticeable whenever it happened). |
|
Without this PR, my game wouldn't run. The more resources your game needs, the worst the FPS gets without this fix. |
|
Noted, I'll take a look at it over the weekend. |
| if (lastFPSUpdateNanos == 0L) { | ||
| lastFPSUpdateNanos = now | ||
| fpsBuffer2sec = 0 | ||
| val ticksPerSecond = if (ticksPerSecond < 0) 60 else ticksPerSecond // For JavaFX loops, cap at 60fps too |
There was a problem hiding this comment.
When ticksPerSecond is -1 or 0, JavaFX will match the display refresh rate (which is what we want), so we shouldn't cap it at 60
| if (now - lastFPSUpdateNanos >= 2_000_000_000) { | ||
| // Update the FPS value every 500 millis | ||
| val timeSinceLastFPSUpdateNanos = now - lastFPSUpdateNanos; | ||
| if (timeSinceLastFPSUpdateNanos >= 500_000_000) { |
There was a problem hiding this comment.
I wonder if it's beneficial for the developers to have access to this "fps refresh interval", then we move the responsibility from us to them. We use a default value of X and let them pick a different one to suit their project.
|
Hi @AlmasB, I've added the possibility to configure the FPS sampling rate. Thanks, |
Hi,
Issue Link: #1297
This PR contains fixes for the FPS & the TPF calculations. The FPS calculation is now refreshed every 500 millis. The TPF will be based on current TPF.
Note that this change was a game changer. I was experiencing frequent freeze and FPS issues (I was wondering also why the Profiler was showing 60 steady FPS when it was lagging). With this change, the Profiler will show realtime FPS and recover from lag instantly (when possible).