Charge NFT contract deploy gas on MsgLiquify #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBorst
changed the title
The initial MsgLiquify implementation had the NFT deployed in the EVM by the microtx module, and ignored the gas cost incurred by the EVM operations. A contract deploy is a pretty hefty op to allow for free so to prevent spam we need to charge the user.
ChristianBorst
force-pushed
the
christianborst/liquify-gas
branch
from
537cd1d to
41b20f2
Compare
ChristianBorst
changed the title
MsgLiquify deploys a NFT contract with address derived from the user's EVM address and their nonce. However the nonce is only incremented on every Tx, so if a user submits multiple MsgLiquify in the same Tx there may be deployment issues and undefined behavior.
jkilpatr
approved these changes
Feb 27, 2024
|
Nice simplification here avoiding the transfer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #49 is merged and this branch is rebasedPromising issue found in development: the old gas limit of 1,000,000 was not sufficient after the
Charge liquified account gas on MsgLiquifychange, the new limit needed to be 2,500,000 gas, because the test was using 2347396 locally.