WIP: Set proper account types + pubkeys #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial MsgLiquify implementation had the NFT deployed in the EVM by the microtx module, and ignored the gas cost incurred by the EVM operations. A contract deploy is a pretty hefty op to allow for free so to prevent spam we need to charge the user.
MsgLiquify deploys a NFT contract with address derived from the user's EVM address and their nonce. However the nonce is only incremented on every Tx, so if a user submits multiple MsgLiquify in the same Tx there may be deployment issues and undefined behavior.
Keplr (and likely other wallets) expect to see Cosmos account types (e.g. vesting or BaseAccount types) for Cosmos chains but error when the sequence query returns an EthAccount type. To avoid this issue we default to Cosmos BaseAccounts on creation but update the account type when setting the PubKey if it is an Ethermint account. Vesting accounts are left unchanged.
|
Closed in favor of a branch with a better implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 problems solved with this PR: