Fix pubkeys and account types in AnteHandlers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBorst
force-pushed
the
christianborst/ante-accounts
branch
from
b65921e to
7cc0e00
Compare
jkilpatr
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
This covers a lot of ground. Is there any way we can unit test stuff like sig verification or sequence increment? the basics to ensure no one accidentally leaves anything related to the ante-handler setup improperly in the future.
Also looks like a go test failure
ChristianBorst
force-pushed
the
christianborst/ante-accounts
branch
from
47207db to
f4b260d
Compare
These decorators migrate incorrectly assigned Ethermint keys to EthAccounts and set the pubkey on EVM Tx execution
This change requires an update to althea-net/ethermint so that the EVM only creates the correct kind of accounts. When we set BaseAccount as the default account type, it broke contract deployment because the EthAccount is what makes code (especially the code hash) deployable at an address. Because ethermint was updated it was necessary to update the canto fork as well. The new paradigm initializes the evmKeeper with a special prototypical account creation function to create a new EthAccount with an address set. This function is used in the evm module and also throughout the ante handlers everywhere a new account is created to ensure Ethermint keys and contract accounts are all initialized correctly. To ensure these changes work, ante handler tests have been copied and enhanced from the ethermint project. I copied the general ante handler tests but also added ones for the new EthSetPubkey and SetAccountType decorators. The old antehandler is also checked to ensure the changes fix the issue.
ChristianBorst
force-pushed
the
christianborst/ante-accounts
branch
from
f4b260d to
9b7b436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.