Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nativedex governance module #59

Closed
wants to merge 23 commits into from
Closed

Nativedex governance module #59

wants to merge 23 commits into from

Conversation

ChristianBorst
Copy link
Collaborator

@ChristianBorst ChristianBorst commented Apr 18, 2024 •
edited
Loading

No description provided.

@ChristianBorst ChristianBorst force-pushed the christianborst/dex-gov branch 2 times, most recently from 0510acc to 210a5f2 Compare April 19, 2024 23:33
@ChristianBorst ChristianBorst mentioned this pull request Apr 19, 2024
Merged
@ChristianBorst ChristianBorst force-pushed the christianborst/dex-gov branch 2 times, most recently from 6324cda to 373e4a4 Compare April 20, 2024 16:06
jkilpatr
jkilpatr approved these changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@jkilpatr jkilpatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. I'd like to go over some parts of it on a call just to be sure of my own understanding. I'll also want to look at it again once #58 is merged and the diff is smaller.

integration_tests/test_runner/src/tests/dex.rs Show resolved Hide resolved
@ChristianBorst ChristianBorst force-pushed the christianborst/dex-gov branch from 1c48836 to eed1fb2 Compare April 22, 2024 19:33
@ChristianBorst ChristianBorst force-pushed the christianborst/dex-gov branch from eed1fb2 to 069832a Compare April 22, 2024 20:41
@ChristianBorst ChristianBorst force-pushed the christianborst/dex-gov branch from 446295d to 81a70fe Compare April 24, 2024 21:51
@ChristianBorst ChristianBorst force-pushed the christianborst/dex-gov branch from 81a70fe to 4b2a379 Compare April 24, 2024 21:57
@ChristianBorst
Copy link
Collaborator Author

Merged manually after rebasing onto main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkilpatr jkilpatr jkilpatr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianBorst @jkilpatr