Neutrino upgrade

.github/workflows/integration-tests.yml

@@ -14,205 +14,201 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: Swatinem/rust-cache@v1
+      - uses: Swatinem/rust-cache@v2
         with:
-          working-directory: integration-tests/
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Build Integration Tests
         run: cd integration_tests && cargo check --all --verbose
   native_token:
     runs-on: ubuntu-latest
     needs: build
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
-        continue-on-error: true
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
-      - name: Prune cache to keep the size down
-        run: docker builder prune -af && docker system prune -af
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Test the native token features of the EVM
-        run: tests/all-up-test.sh NATIVE_TOKEN
+        run: tests/all-up-test-ci.sh NATIVE_TOKEN
   lockup:
     runs-on: ubuntu-latest
     needs: native_token
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Lock up the chain and ensure funds are not transferrable
-        run: tests/all-up-test.sh LOCKUP
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh LOCKUP
   microtx_fees:
     runs-on: ubuntu-latest
     needs: native_token
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Assert that fees are collected by the microtx module
-        run: tests/all-up-test.sh MICROTX_FEES
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh MICROTX_FEES
   erc20_conversion:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Test the erc20 module's token conversion functionality
-        run: tests/all-up-test.sh ERC20_CONVERSION
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh ERC20_CONVERSION
   liquid_accounts:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Test the microtx module's liquid infrastructure accounts functions
-        run: tests/all-up-test.sh LIQUID_ACCOUNTS
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh LIQUID_ACCOUNTS
   ica_host:
-    needs: native_token
+    #needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Test the interchain accounts host module on Althea-L1
-        run: tests/all-up-test.sh ICA_HOST
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh ICA_HOST
   ONBOARDING_DEFAULT_PARAMS:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Starts the onboarding module with the default params
-        run: tests/all-up-test.sh ONBOARDING_DEFAULT_PARAMS
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh ONBOARDING_DEFAULT_PARAMS
   ONBOARDING_DISABLED_WHITELISTED:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Starts the onboarding module disabled with a whitelisted channel
-        run: tests/all-up-test.sh ONBOARDING_DISABLED_WHITELISTED
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh ONBOARDING_DISABLED_WHITELISTED
   ONBOARDING_DISABLE_AFTER:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Starts the onboarding module permissively, but disables it after a transfer
-        run: tests/all-up-test.sh ONBOARDING_DISABLE_AFTER
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh ONBOARDING_DISABLE_AFTER
   ONBOARDING_DELIST_AFTER:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Starts the onboarding module permissively, but removes the channel from the whilelist after a transfer
-        run: tests/all-up-test.sh ONBOARDING_DELIST_AFTER
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh ONBOARDING_DELIST_AFTER
   DEX:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Performs basic DEX tests
-        run: tests/all-up-test.sh DEX
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh DEX
   DEX_UPGRADE:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Tests the DEX callpath upgrade functionality
-        run: tests/all-up-test.sh DEX_UPGRADE
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh DEX_UPGRADE
   DEX_SAFE_MODE:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Tests the DEX safe mode lockdown functionality
-        run: tests/all-up-test.sh DEX_SAFE_MODE
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh DEX_SAFE_MODE
   DEX_OPS_PROPOSAL:
     needs: native_token
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: jpribyl/[email protected]
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
         with:
-          key: integration-test-cache-{hash}
-          restore-keys: |
-            integration-test-cache-
+          workspaces: integration_tests/
+          cache-on-failure: true
       - name: Tests the nativedex OpsProposal function
-        run: tests/all-up-test.sh DEX_OPS_PROPOSAL
-        env:
-          NO_IMAGE_BUILD: True
+        run: tests/all-up-test-ci.sh DEX_OPS_PROPOSAL
+  EVM_FEE_BURNING:
+    needs: native_token
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
+        with:
+          workspaces: integration_tests/
+          cache-on-failure: true
+      - name: Checks that evm fees are truly burned
+        run: tests/all-up-test-ci.sh EVM_FEE_BURNING
+  UPGRADE:
+    needs: native_token
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-go@v5
+      - uses: Swatinem/rust-cache@v2
+        with:
+          workspaces: integration_tests/
+          cache-on-failure: true
+      - name: Tests the Neutrino upgrade
+        run: tests/run-upgrade-test.sh v1.4.0

.gitignore

@@ -33,6 +33,7 @@ mytestnet
 coverage.txt
 profile.out
 tests/dockerfile/althea.tar.gz
+test-ready-to-run
 
 # Vagrant
 .vagrant/

app/ante/charge_gasfree_fees_test.go

@@ -192,6 +192,6 @@ func (suite *AnteTestSuite) TestChargeGasfreeFeesDecorator() {
 	// nolint: exhaustruct
 	suite.app.GasfreeKeeper.SetGasFreeMessageTypes(bothGasfreeCtx, []string{sdk.MsgTypeURL(&microtxtypes.MsgMicrotx{}), sdk.MsgTypeURL(&banktypes.MsgSend{})})
 
-	// Expect the error from the mempool fee decorator to contain something like "insufficient fees; got: x required: provided fee < minimum global feey"
+	// Expect the error from the mempool fee decorator to contain something like "insufficient fees; got: x required: provided fee < minimum global fee y"
 	suite.Require().NoError(runGasfreeTests(suite, gasfreeMicrotxCtx, gasfreeSendCtx, noGasfreeCtx, bothGasfreeCtx, msgMicrotxTx, msgSendTx, bothTx, addr, testDenom))
 }

app/ante/cosmos_handler_test.go

@@ -115,8 +115,8 @@
 	// nolint: exhaustruct
 	suite.app.GasfreeKeeper.SetGasFreeMessageTypes(bothGasfreeCtx, []string{sdk.MsgTypeURL(&microtxtypes.MsgMicrotx{}), sdk.MsgTypeURL(&banktypes.MsgSend{})})
 
-	// Expect the error from the mempool fee decorator to contain something like "insufficient fees; got: x required: provided fee < minimum global feey"
-	suite.Require().NoError(runBypassTest(suite, "insufficient fees; got:", gasfreeMicrotxCtx, gasfreeSendCtx, noGasfreeCtx, bothGasfreeCtx, msgMicrotxTx, msgSendTx, bothTx))
+	// Expect the error from the mempool fee decorator to contain something like "insufficient fees; got: x required: provided fee < minimum global fee"
+	suite.Require().NoError(runBypassTest(suite, "provided fee < minimum global fee", gasfreeMicrotxCtx, gasfreeSendCtx, noGasfreeCtx, bothGasfreeCtx, msgMicrotxTx, msgSendTx, bothTx))
 }
 
 // Checks that the MinGasPrices antedecorator is bypassed for applicable txs
@@ -126,7 +126,7 @@
 	suite.ctx = suite.ctx.WithIsCheckTx(false) // use checkTx false to avoid triggering mempool fee decorator
 	feemarketParams := suite.app.FeemarketKeeper.GetParams(suite.ctx)
 	feemarketParams.MinGasPrice = sdk.NewDec(100)
 	suite.app.FeemarketKeeper.SetParams(suite.ctx, feemarketParams) // Set the min gas price to trigger failure in the MinGasPricesDecorator
 	privKey := suite.NewCosmosPrivkey()
 	addr := sdk.AccAddress(privKey.PubKey().Address().Bytes())
 	suite.FundAccount(suite.ctx, addr, big.NewInt(10000000000))
@@ -158,7 +158,7 @@
 	suite.ctx = suite.ctx.WithIsCheckTx(false) // use checkTx false to avoid triggering mempool fee decorator
 	feemarketParams := suite.app.FeemarketKeeper.GetParams(suite.ctx)
 	feemarketParams.MinGasPrice = sdk.NewDec(0)
 	suite.app.FeemarketKeeper.SetParams(suite.ctx, feemarketParams) // Set the min gas price to avoid failure from MinGasPricesDecorator
 	privKey := suite.NewCosmosPrivkey()
 	addr := sdk.AccAddress(privKey.PubKey().Address().Bytes())
 	suite.FundAccount(suite.ctx, addr, big.NewInt(1))

app/ante/eth_set_pubkey_test.go

@@ -153,19 +153,6 @@ func (suite *AnteTestSuite) TestEthSetPubkeyHandler() {
 				suite.Require().Error(err)
 			}
 			suite.Require().True(tc.correctPubKey(pubKey), "PubKey type incorrect after AnteHandler")
-
-			// Now check the old antehandler against the same Tx, see if it would create a pubkey
-			ctx, _ = suite.ctx.CacheContext()
-			suite.testCaseSetup(ctx, addr, tc.startBaseAcc)
-			// nolint: errcheck
-			_, _ = suite.oldAnteHandler(ctx, tx, false)
-			acc = suite.app.AccountKeeper.GetAccount(ctx, addr)
-			pubKey = acc.GetPubKey()
-			if tc.expOldPubKey {
-				suite.Require().True(pubKey != nil && tc.correctPubKey(pubKey), "Old ante handler should have set a pubkey")
-			} else {
-				suite.Require().True(pubKey == nil, "Old ante handler should have set a pubkey")
-			}
 		})
 	}
 }