Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated ENV format and updated go in Dockerfile #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wlaoh
Copy link

@wlaoh wlaoh commented Oct 21, 2024

  1. Docker has deprecated the ENV KEY VALUE format of setting environment variables to the ENV KEY=VALUE format. Updated it in this PR.
  2. The go.mod file specifies golang version 1.19, however this Dockerfile was still using 1.15. This was causing issues due to to changes that go made in 1.19 in how it handles GOROOT: https://go-review.googlesource.com/c/go/+/53370

I was not able to successfully build the docker container until I made these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant