forked from Hillobar/Rope
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Auto Swap for videos as well #24
Open
JaredTherriault
wants to merge
66
commits into
Alucard24:development
Choose a base branch
from
JaredTherriault:expose-auto-swap-to-videos
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Expose Auto Swap for videos as well #24
JaredTherriault
wants to merge
66
commits into
Alucard24:development
from
JaredTherriault:expose-auto-swap-to-videos
+746
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs panel with scrollwheel when hovering scrollbar
Since frame jumping doesn't work when playback is active by design
sort videos and faces lists alphanumerically
fix scrollwheel behaviour for linux and mac, allow scrolling paramete…
Fix mouse wheel seeking on timeline for Unix
…ng-frames Stop playback when attempting to jump frames via button or mouse wheel
add avg fps entry so users can find the best settings for realtime pl…
Fix divide by zero issue
… send it out of bounds
…error Clamp values when creating restore mouth mask to ensure offsets don't…
Parameterize history limit
Add tooltip for video tiles with untruncated filename
…t-issue Update VideoManager.py
3-4x speedup on my system! Possibly better on CPUs with more cored
Parallelize loading of input videos
I know it's intentionally not a video feature since the first frame of a video doesn't necessarily have a face in it, but there are plenty of videos that do start with a face. I think it's worth letting the user elect to it.
Expose Auto Swap for videos as well
Use Alt+click to toggle "lock" a source face or saved embedding to always be on and highlighted in green. When locked, source faces and saved embeddings won't be cleared when selecting new target faces or input images/videos, even with auto-swap toggled off. This allows the end user to maintain a specific "look" for a target face, even between videos.
Add 'locking' mechanism for source faces and embeddings (Alt+click_
Support motion images
This reverts commit b71e46b.
Add loop playback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's intentionally not a video feature since the first frame of a video doesn't necessarily have a face in it, but there are plenty of videos that do start with a face. I think it's worth letting the user elect to it.