-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to accept epoch when moment is initialized #18
base: master
Are you sure you want to change the base?
Conversation
@atuttle do you think you could merge soon? |
I spent some time working on it last weekend. I'm eager to get it in but I need to get all of the tests passing first. |
Awesome, Thanks! -- Arthur On Thu, Jun 23, 2016 at 9:46 AM, Adam Tuttle [email protected]
|
any luck? |
Not yet. Been underwater between work and freelance stuff. I forget exactly where I left off, but I believe I made some test additions & changes, and also may have made some modifications to your changes. If I get a chance I'd like to push a branch with all of that in it so you could pick up where I left off. Sorry for being the bottleneck! |
Hey if you need another maintainer I could find time here and there to put -- Arthur On Fri, Jul 8, 2016 at 3:54 PM, Adam Tuttle [email protected]
|
Thanks! I'll see if I can get that branch up with tests asap. |
@atuttle how is it going with this one? |
@atuttle if you need help getting PRs in please let me know! ( It should not take months to get a PR merged ) |
Generally it doesn't. Your change is a good idea, but the implementation broke just as much, if not more, than it fixed. ;) Sorry, I just haven't had time to come back to this yet. |
No description provided.