Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): useObservablesProxy calls setState during a render #1028

Merged

Conversation

divdavem
Copy link
Member

fix #1027

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (e17789c) to head (ce1208c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
react/headless/src/utils/stores.ts 94.44% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   91.79%   91.81%   +0.01%     
==========================================
  Files          99       99              
  Lines        2644     2674      +30     
  Branches      438      442       +4     
==========================================
+ Hits         2427     2455      +28     
- Misses        140      141       +1     
- Partials       77       78       +1     
Flag Coverage Δ
e2e 83.20% <94.73%> (+0.11%) ⬆️
unit 84.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem divdavem force-pushed the fixUseObservableProxy branch from c801b33 to 0ea9452 Compare December 3, 2024 14:59
@divdavem divdavem changed the title [WIP] fix(react): useObservablesProxy calls setState during a render fix(react): useObservablesProxy calls setState during a render Dec 3, 2024
@divdavem divdavem marked this pull request as ready for review December 3, 2024 15:12
@divdavem divdavem force-pushed the fixUseObservableProxy branch from 0ea9452 to 77586a2 Compare December 3, 2024 15:37
@divdavem divdavem force-pushed the fixUseObservableProxy branch from 77586a2 to aaf151b Compare December 10, 2024 17:35
@divdavem divdavem force-pushed the fixUseObservableProxy branch from aaf151b to ce1208c Compare December 11, 2024 09:50
@quentinderoubaix quentinderoubaix merged commit c7e05dc into AmadeusITGroup:main Dec 11, 2024
16 checks passed
@divdavem
Copy link
Member Author

@quentinderoubaix Thank you for reviewing and merging my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] React useObservablesProxy calls a setState during a render
2 participants