Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): skip flaky unit test #608

Merged

Conversation

quentinderoubaix
Copy link
Contributor

@quentinderoubaix quentinderoubaix commented Mar 19, 2024

Skip flaky unit test.
Fix will be tracked with #609

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (8c6fcf4) to head (9b5f2a3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   92.34%   92.12%   -0.23%     
==========================================
  Files         104      104              
  Lines        2234     2234              
  Branches      398      398              
==========================================
- Hits         2063     2058       -5     
- Misses        103      108       +5     
  Partials       68       68              
Flag Coverage Δ
e2e 84.72% <ø> (ø)
unit 88.79% <ø> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fbasso fbasso self-requested a review March 19, 2024 09:33
Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me !

@quentinderoubaix
Copy link
Contributor Author

thx for the review @fbasso !

@quentinderoubaix quentinderoubaix merged commit 7a21777 into AmadeusITGroup:main Mar 19, 2024
15 of 16 checks passed
@quentinderoubaix quentinderoubaix deleted the skip-flaky-unit branch March 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants