-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing devDep to schematics #2491
Open
kpanot
wants to merge
1
commit into
main
Choose a base branch
from
feature/add-missing-dev-dep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+53
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
project:@ama-sdk/core
project:@ama-sdk/client-fetch
project:@ama-sdk/client-angular
project:@ama-sdk/client-beacon
project:@o3r/analytics
project:@o3r/application
project:@o3r/components
project:@o3r/extractors
project:@o3r/localization
project:@o3r/new-version
project:@o3r/schematics
project:@o3r/stylelint-plugin
project:audit-gh-action
project:cascading-gh-action
project:get-npm-tag-gh-action
project:new-version-gh-action
project:release-gh-action
labels
Nov 20, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kpanot
force-pushed
the
feature/add-missing-dev-dep
branch
from
November 20, 2024 17:05
fc53c8f
to
4406b6b
Compare
cpaulve-1A
previously approved these changes
Nov 21, 2024
fpaul-1A
reviewed
Nov 21, 2024
packages/@o3r/schematics/src/rule-factories/ng-add/ng-add.helpers.ts
Outdated
Show resolved
Hide resolved
kpanot
force-pushed
the
feature/add-missing-dev-dep
branch
from
November 22, 2024 01:08
41215f1
to
8680f2a
Compare
vscaiceanu-1a
previously approved these changes
Nov 22, 2024
kpanot
force-pushed
the
feature/add-missing-dev-dep
branch
2 times, most recently
from
November 22, 2024 15:18
580d40a
to
d26cf25
Compare
fpaul-1A
reviewed
Nov 22, 2024
kpanot
force-pushed
the
feature/add-missing-dev-dep
branch
from
November 22, 2024 16:28
d26cf25
to
2cd00d3
Compare
fpaul-1A
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
project:@ama-sdk/client-angular
project:@ama-sdk/client-beacon
project:@ama-sdk/client-fetch
project:@ama-sdk/core
project:audit-gh-action
project:cascading-gh-action
project:get-npm-tag-gh-action
project:new-version-gh-action
project:@o3r/analytics
project:@o3r/application
project:@o3r/components
project:@o3r/extractors
project:@o3r/localization
project:@o3r/new-version
project:@o3r/schematics
project:@o3r/stylelint-plugin
project:release-gh-action
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
fix: add missing devDep to schematics
Related issues
- No issue associated -