Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update behaviour of Header and related components #1607

Draft
wants to merge 58 commits into
base: develop
Choose a base branch
from
Draft

feat!: Update behaviour of Header and related components #1607

wants to merge 58 commits into from

Commits on Sep 30, 2024

  1. Simplify rigourously

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b8bac3d View commit details
    Browse the repository at this point in the history

  2. Change menu prop from ReactNode to callback function

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e329c9a View commit details
    Browse the repository at this point in the history

  3. Implement wrapping in two halves

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    359edc6 View commit details
    Browse the repository at this point in the history

  4. Wrap Header and Footer stories in Screen

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    285a869 View commit details
    Browse the repository at this point in the history

  5. Introduce component for buttons in page menu

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e4f6df5 View commit details
    Browse the repository at this point in the history

  6. Use Page Menu in Header (incorrectly for now)

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    73e88f9 View commit details
    Browse the repository at this point in the history

  7. Allow icon in Page Menu Button

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    29bb49f View commit details
    Browse the repository at this point in the history

  8. Allow Grid to render a different HTML element

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    834e72c View commit details
    Browse the repository at this point in the history

  9. Make Header render its own Grid

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c6efcef View commit details
    Browse the repository at this point in the history

  10. Make Leader render its children

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e6e5cf2 View commit details
    Browse the repository at this point in the history

  11. Include menu button in Page Menu

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1a28c0c View commit details
    Browse the repository at this point in the history

  12. Rename links prop to menu

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7fa2903 View commit details
    Browse the repository at this point in the history

  13. Update homepage example

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0615ff6 View commit details
    Browse the repository at this point in the history

  14. Make Grid a decorator in Mega Menu stories for easier reuse

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9f69f31 View commit details
    Browse the repository at this point in the history

  15. Simplify white space in Header

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c8f8f91 View commit details
    Browse the repository at this point in the history

  16. Allow logo to grow a bit in wide windows

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ca7fa54 View commit details
    Browse the repository at this point in the history

  17. Hide secondary page menu items in narrow windows

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6432adc View commit details
    Browse the repository at this point in the history

  18. Improve spacing in page menu

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5f547ec View commit details
    Browse the repository at this point in the history

  19. Merge branch 'develop' into poc/DES-884-single-line-header

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    63b43c7 View commit details
    Browse the repository at this point in the history

  20. Remove obsolete class name

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9e9fd4b View commit details
    Browse the repository at this point in the history

  21. Prefer class name over pseudo-selector

    @VincentSmedinga
    VincentSmedinga committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f2f2796 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'develop' into poc/DES-884-single-line-header

    @VincentSmedinga
    VincentSmedinga authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    30fcd0d View commit details
    Browse the repository at this point in the history

  2. Use Text Level 5 for application name

    @VincentSmedinga
    VincentSmedinga committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4664490 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Remove prop that prevents a Page Menu to wrap

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    89a8b10 View commit details
    Browse the repository at this point in the history

  2. Revert Header rendering its own Grid

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b1f2dd6 View commit details
    Browse the repository at this point in the history

  3. Extract Item component for Page Menu

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8220373 View commit details
    Browse the repository at this point in the history

  4. Implement end-alignment on Page Menu alone

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d131cee View commit details
    Browse the repository at this point in the history

  5. Remove beta warnings from Header, Mega Menu and Page Menu

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bfc1d5a View commit details
    Browse the repository at this point in the history

  6. WIP Docs

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bd11475 View commit details
    Browse the repository at this point in the history

  7. Fix things

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    54957de View commit details
    Browse the repository at this point in the history

  8. Use any to type ref for polymorphic components

    @VincentSmedinga
    VincentSmedinga committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0798488 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Finetune space lengths

    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f03164d View commit details
    Browse the repository at this point in the history

  2. Fix gap token name for page menu item

    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a855c31 View commit details
    Browse the repository at this point in the history

  3. Rename mixin

    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    41f6441 View commit details
    Browse the repository at this point in the history

  4. Decrease line height for application name Heading

    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    aa53f36 View commit details
    Browse the repository at this point in the history

  5. Revert "Make Grid a decorator in Mega Menu stories for easier reuse" 

    This reverts commit 9f69f31.

# Conflicts:
#	storybook/src/pages/amsterdam/common/AppHeader.tsx
    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    91c22ae View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into poc/DES-884-single-line-header

    @VincentSmedinga
    VincentSmedinga authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    38d63cb View commit details
    Browse the repository at this point in the history

  7. Make Header render a header element

    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    12be155 View commit details
    Browse the repository at this point in the history

  8. Make Mega Menu render a nav element

    @VincentSmedinga
    VincentSmedinga committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a34fc1b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Let Grid and Grid Cell render any structural tag

    @VincentSmedinga
    VincentSmedinga committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f705b23 View commit details
    Browse the repository at this point in the history

  2. Fix type import

    @VincentSmedinga
    VincentSmedinga committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a669021 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Simplify mega menu stories

    @VincentSmedinga
    VincentSmedinga committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8a64d5b View commit details
    Browse the repository at this point in the history

  2. Deprecate Mega Menu component

    @VincentSmedinga
    VincentSmedinga committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    32b2069 View commit details
    Browse the repository at this point in the history

  3. Implement Mega Menu as pattern in Amsterdam home page

    @VincentSmedinga
    VincentSmedinga committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b62fd4c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into poc/DES-884-single-line-header

    @VincentSmedinga
    VincentSmedinga committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b379529 View commit details
    Browse the repository at this point in the history

  5. Fix empty class name

    @VincentSmedinga
    VincentSmedinga committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8ecf069 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary keys from example

    @VincentSmedinga
    VincentSmedinga committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e6cdd94 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Implement hack to wrap all main navigation in one nav element

    @alimpens
    alimpens committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9657743 View commit details
    Browse the repository at this point in the history

  2. Finetune poc

    @alimpens
    alimpens committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6891717 View commit details
    Browse the repository at this point in the history

  3. Add padding

    @alimpens
    alimpens committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3e20118 View commit details
    Browse the repository at this point in the history

  4. Add toggle button

    @alimpens
    alimpens committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5685c69 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Break up menu in subcomponents

    @alimpens
    alimpens committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0101037 View commit details
    Browse the repository at this point in the history

  2. Remove unused state

    @alimpens
    alimpens committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fbfd1c1 View commit details
    Browse the repository at this point in the history

  3. Merge item and link

    @alimpens
    alimpens committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    10511d5 View commit details
    Browse the repository at this point in the history

  4. Move styling from inline to css

    @alimpens
    alimpens committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    dd1c504 View commit details
    Browse the repository at this point in the history

  5. Cleanup, add MegaMenuSecondaryLinkList

    @alimpens
    alimpens committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b5df56d View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Add minimal version for headers without mega menu

    @alimpens
    alimpens committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    9d595cd View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Fix stories

    @alimpens
    alimpens committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a16e9af View commit details
    Browse the repository at this point in the history