Fix rtags completion over tramp with unsaved buffer for remote file #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use the tramp aware function make-nearby-temp-file to create the tmp file on the remote host (if default-directory is remote). 2. Change the path prefix to a relative path as absolute forces it to always be a local file. 3. Change the path prefix to be unique to rtags as suggested by the documentation for make-temp-file. 4. Use rtags-untrampify on the temp file name so that we pass the local file name to rc on the remote system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to say rtags is awesome and thanks for making my life easier.
To work with my remote project, I followed this PR #546 which was pretty straight forward (it was very helpful so should we add the details to the wiki?). Next, I added company-rtags for completion as described in the wiki#code-completion-in-emacs. However, it would fail with a company async timeout. After quite a bit of digging (and learning 😅 ), I found that rtags elisp code was sending the unsaved buffer as a temp file but this temp file was being created locally. Just a few small changes and everything was working like a charm.
Fixes:
Let me know if there is anything else I can do to make this PR approved.