This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
AP-794: Switch deploy-related tasks to typed interfaces #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the solution
Use static
Contract__factory.createInterface().encodeFunctionData
instead of regularContract_factory.interface.encodeFunctionData
With
Contract_factory.interface.encodeFunctionData
(interface is of generic typeInterface
):With
Contract__factory.createInterface().encodeFunctionData
(interface is of specific typeAPTeamMultiSigInterface
which enforces type-safety):Without updating this, changes in function data or data types will not be registered by TS compiler, causing our tasks to fail during runtime, necessitating a debug session.
With this update, we catch errors during compile-time.
Instructions on making this work
yarn
oryarn install
to install npm dependencies