Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key_error issue #36

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Fix key_error issue #36

merged 5 commits into from
Dec 13, 2024

Conversation

killian-scalian
Copy link
Collaborator

@killian-scalian killian-scalian commented Dec 13, 2024 •
edited
Loading

  • Fix key_error issue
  • remove area_id in some useless places

MartinBelthle
MartinBelthle approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I'll let you write the test you like and if theres' no other file involved you can merge

@killian-scalian killian-scalian merged commit a4217ef into main Dec 13, 2024
8 checks passed
@killian-scalian killian-scalian deleted the fix_key_error_issue branch December 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle approved these changes

@Sigurd-Borge Sigurd-Borge Awaiting requested review from Sigurd-Borge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killian-scalian @MartinBelthle