Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/fe #251

Merged
merged 55 commits into from
Nov 3, 2023
Merged

Refactor/fe #251

merged 55 commits into from
Nov 3, 2023

Conversation

leissa
Copy link
Member

@leissa leissa commented Oct 2, 2023 •
edited
Loading

@leissa
adopting some best practices for cmake
1251b33 
* tests: check for BUILD_TESTING **and** THORIN_BUILD_TESTING
* Debug as default: populate GUI options
@leissa
cmake: use quotes for paths
1f8f1ab
@leissa
oops
5807912
@leissa
cmake: refactoring
56c15e5
@leissa
PROJECT*DIR -> CMAKE_CURRENT*DIR
9787a7a 
This makes thorin as submodule via add_subdirectory more robust.
@leissa
fix paths
0e00330
@leissa
cmake: consistent style
137079c 
* install_exports -> thorin_exports
@leissa
cleanup
681a338
@leissa
remove THORIN_BUILD_TESTING option
478c4b4 
simply use the global BUILD_TESTING option
@leissa
modules -> external + added leissa/fe
b1afd2f
@leissa
thorin_exports -> thorin-targets
0e9e087
@leissa
thorin/util/assert.h -> fe/assert.h
61e0c4c
@leissa
Merge branch 'refactor/cmake' into refactor/fe
6046e7c
@leissa
submodules
344e418
@leissa
moving submodules around
1c35e0c
@leissa
thorin/util/cast.h -> fe/cast.h
25d0d7c
@leissa
doxygen fixes
14d49a9
@leissa
use fe/loc.h and fe/sym.h
7d2ff92
@leissa
docs fix
e8c0960
@leissa
porting World::arena_ to fe::Arena
a081deb
@leissa
compile fix
7b10207
@leissa
fe: bump
1427ba7
@leissa
thorin/util/utf8.* -> fe/utf.8 / fe/lexer.h
7fc6e49
@leissa
bug fixes
32fb6cb
@leissa
wip: porting Parser to fe
7795b25
@leissa
wip: porting to fe::Parser
0cc22d0
@leissa
more porting to fe::Parser
c0f79d0
@leissa
using default impl for Pos/Loc ostream operators
514d546
@leissa
simplify
b5519be
@leissa
porting to fe::Parser::expect
84bf137
@leissa
Copy link
Member Author

leissa commented Oct 11, 2023 •
edited
Loading

@fodinabor can you have a look at the failing macos test cases? I upgraded to macos-latest and your FileCheck magic needs an update.

@leissa leissa marked this pull request as ready for review October 11, 2023 20:31
@leissa
Copy link
Member Author

leissa commented Nov 2, 2023

@fodinabor , @NeuralCoder3 : anyone has the mercy to give their 2 cents on this? :)

fodinabor
fodinabor reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@fodinabor fodinabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, it looks very NFC, which is probably what you want, so, LGTM.
Just a few nits.

thorin/fe/lexer.cpp Outdated Show resolved Hide resolved
thorin/fe/lexer.cpp Outdated Show resolved Hide resolved
thorin/util/dl.h Show resolved Hide resolved
@leissa leissa merged commit ad30783 into master Nov 3, 2023
12 checks passed
@leissa leissa deleted the refactor/fe branch November 3, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fodinabor fodinabor fodinabor left review comments

@NeuralCoder3 NeuralCoder3 Awaiting requested review from NeuralCoder3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leissa @fodinabor