-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/blockexpr #274
Refactor/blockexpr #274
Conversation
* porting from BlockExpr away * Bug fix in parser when dealing with erroneous patterns
I think this syntax is confusing. I think a syntax like |
gtest/test.cpp
Outdated
EXPECT_EQ(c, r); | ||
// EXPECT_TRUE(r->is_term()); | ||
// EXPECT_TRUE(!r->type()->is_term()); | ||
// EXPECT_EQ(c, r); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these lines no longer true?
I tried
Any other ideas? |
I think I'm merging for now but add an issue for the alias pattern that we want to have a nicer syntax here. After all, we want to rename Thorin and for this reason I don't want to have stale branches lying around ... |
Plz first give #273 your blessing.
{ d* e }
.simply use
d* e
instead and if you really want to use delimiters use a tuple:(d* e)
abc::(a: A, b: B, c: C)
->(a: A, b: B, c: C)::abc
.This is simpler to parse and makes more sense as the identifier
abc
is only available after having processed the whole tuple pattern.