Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Raise warning if value= is specified for anything but a payable function [APE-1283] #1599

Merged
merged 37 commits into from
Aug 17, 2023
Merged

feat: Raise warning if value= is specified for anything but a payable function [APE-1283] #1599

merged 37 commits into from
Aug 17, 2023

Commits on May 31, 2023

  1. added option for setting the password to unlock accounts from env var… 

    …iables and docs updated
    @Aviksaikat
    Aviksaikat committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2ec0095 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ApeWorX:main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored May 31, 2023
    Configuration menu
    Copy the full SHA
    395e82a View commit details
    Browse the repository at this point in the history

  3. code formmated for according to black & fixed type-check

    @Aviksaikat
    Aviksaikat committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5171da9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feat/accounts-env-passphrase' of github.com:Aviksaikat/… 

    …ape into feat/accounts-env-passphrase
    @Aviksaikat
    Aviksaikat committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ec46049 View commit details
    Browse the repository at this point in the history

  5. added option for setting the password to unlock accounts from env var… 

    …iables and docs updated
    @Aviksaikat
    Aviksaikat committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2869a41 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Merge branch 'main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    5fbf133 View commit details
    Browse the repository at this point in the history

  2. Update docs/userguides/accounts.md 

    Co-authored-by: antazoey <[email protected]>
    @Aviksaikat @antazoey
    Aviksaikat and antazoey authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    67a4cdd View commit details
    Browse the repository at this point in the history

  3. Update docs/userguides/accounts.md 

    Co-authored-by: antazoey <[email protected]>
    @Aviksaikat @antazoey
    Aviksaikat and antazoey authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    ed45f8d View commit details
    Browse the repository at this point in the history

  4. Update docs/userguides/accounts.md 

    Co-authored-by: antazoey <[email protected]>
    @Aviksaikat @antazoey
    Aviksaikat and antazoey authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    4de26f4 View commit details
    Browse the repository at this point in the history

  5. updated passphrase arg type from Optional to str

    @Aviksaikat
    Aviksaikat committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    fcf719d View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Merge branch 'main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    c7d553d View commit details
    Browse the repository at this point in the history

  2. Update docs/userguides/accounts.md 

    Co-authored-by: antazoey <[email protected]>
    @Aviksaikat @antazoey
    Aviksaikat and antazoey authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    56f5943 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. added tests for loading passphrase from env & sign

    @Aviksaikat
    Aviksaikat committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    64e68e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Merge branch 'main' into feat/accounts-env-passphrase

    @antazoey
    antazoey authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    f5ee6e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'ApeWorX:main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    248a7ce View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Merge branch 'ApeWorX:main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    3add012 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Merge branch 'ApeWorX:main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    8fa0c75 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Merge branch 'ApeWorX:main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8f65b3f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Merge branch 'ApeWorX:main' into feat/accounts-env-passphrase

    @Aviksaikat
    Aviksaikat authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    13baf41 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'ApeWorX:main' into feat/Raise-warning-if-value

    @Aviksaikat
    Aviksaikat authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3554877 View commit details
    Browse the repository at this point in the history

  2. feat: Raise warning if value= is specified for anything but a payable… 

    … function [APE-874] #1396
    @Aviksaikat
    Aviksaikat committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f9e4fa0 View commit details
    Browse the repository at this point in the history

  3. indentation fixed with black

    @Aviksaikat
    Aviksaikat committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3380bab View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Update src/ape/contracts/base.py 

    Co-authored-by: El De-dog-lo <[email protected]>
    @Aviksaikat @fubuloubu
    Aviksaikat and fubuloubu authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    daa44e1 View commit details
    Browse the repository at this point in the history

  2. made a separate exception class for the exception. code refactored

    @Aviksaikat
    Aviksaikat committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ccf6ed7 View commit details
    Browse the repository at this point in the history

  3. indentation fixed with black & test added but it's broken. need help

    @Aviksaikat
    Aviksaikat committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c47e037 View commit details
    Browse the repository at this point in the history

  4. indentation fixed with black & test added but it's broken. need help

    @Aviksaikat
    Aviksaikat committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9950ed1 View commit details
    Browse the repository at this point in the history

  5. proper exception added

    @Aviksaikat
    Aviksaikat committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    898b1c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. test_sending_funds_to_non_payable_constructor_by_contractContainerDep… 

    …loy test added & working on test_sending_funds_to_non_payable_constructor_by_accountDeploy
    @Aviksaikat
    Aviksaikat committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    7dbb8cb View commit details
    Browse the repository at this point in the history

  2. test_sending_funds_to_non_payable_constructor_by_contractContainerDep… 

    …loy test added & test_sending_funds_to_non_payable_constructor_by_accountDeploy & hopefully final commit. file updated, ~ape/api/accounts.py, ~ape/contracts/base.py, ~ape/exceptions.py, tests/functional/test_contract_instance.py
    @Aviksaikat
    Aviksaikat committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    a686816 View commit details
    Browse the repository at this point in the history

  3. ran the fomatter script to pass the linting tests

    @Aviksaikat
    Aviksaikat committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    1688a82 View commit details
    Browse the repository at this point in the history

  4. fixed the mess created by flake8. Opps :(

    @Aviksaikat
    Aviksaikat committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    f153b7a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feat/Raise-warning-if-value

    @Aviksaikat
    Aviksaikat authored Aug 12, 2023
    Configuration menu
    Copy the full SHA
    9a8cc54 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. SendingFundsToNonPayableConstructorError renamed to MethodNonPayableE… 

    …rror & exception type changed from ApeException to ContractError
    @Aviksaikat
    Aviksaikat committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    9371a02 View commit details
    Browse the repository at this point in the history

  2. SendingFundsToNonPayableConstructorError renamed to MethodNonPayableE… 

    …rror & exception type changed from ApeException to ContractError. fixing the last blunder
    @Aviksaikat
    Aviksaikat committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    23f66ec View commit details
    Browse the repository at this point in the history

  3. MethodNonPayableError exception type changed from ApeException to Con… 

    …tractError
    @Aviksaikat
    Aviksaikat committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    7fc28a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update src/ape/exceptions.py

    @fubuloubu
    fubuloubu authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d2bf5c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Merge branch 'main' into feat/Raise-warning-if-value

    @fubuloubu
    fubuloubu authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    26f027c View commit details
    Browse the repository at this point in the history