fix: issues causing dev messages from working on vyper 0.3.9 [APE-1320] #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
4 tasks
antazoey
commented
Aug 25, 2023
|
|
||
|
|
||
| @geth_process_test | ||
| def test_dev_revert(owner, reverts_contract_instance, geth_provider): |
There was a problem hiding this comment.
i had to move the dev messages check to ape-vyper since they now utilize the actual CompilerAPI methods for tracing a source; it makes sense they live there anyway, as they will differ from compiler to compiler a lot and this feature doesn't come with Core out of the box. That being said, it'd be nice to have a really simple source tracers for interfaces that treats each call as a single statement (just an idea)
fubuloubu
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #
How I did it
How to verify it
Checklist