-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to load contracts using ABIs
[APE-1334]
#1635
feat: option to load contracts using ABIs
[APE-1334]
#1635
Conversation
ABIs
ABIs
[APE-1334]
ABIs
[APE-1334]ABIs
[APE-1334]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have like a hundred nits but the PR looks pretty good!
Do you mind tightening it up some by:
- Avoiding
...
in the example - Removing some of the superfluous comments
- Using
abi_list = json.loads(abi.read_text())
instead of the with open block
tests/functional/data/contracts/ethereum/solidity_contract_json.json
Outdated
Show resolved
Hide resolved
@Aviksaikat is busy and said they dont mind if i address the nits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Wow!!, the refactoring looks leet. You really cleaned up the mess I created. I will try my best to follow in your footsteps in future PRs. |
What I did
Added the option to load contracts using
ABIs
.Example
fixes: #1615
How I did it
Added the option to pass
abi
in theinstance_at
method ofape.managers.chain.ContractCache
Class.How to verify it
pyproject.toml
for poetrypoetry install && poetry shell
pip install -e <path/to/this/revision>
Checklist