-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more source traceback improvements [APE-1335] #1636
Merged
antazoey
merged 13 commits into
ApeWorX:main
from
antazoey:feat/show-source-tb-on-fail-dev-message
Aug 29, 2023
Merged
fix: more source traceback improvements [APE-1335] #1636
antazoey
merged 13 commits into
ApeWorX:main
from
antazoey:feat/show-source-tb-on-fail-dev-message
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
fix: show source traceback when can't find dev message
fix: show source traceback when can't find dev message [APE-1335]
Aug 29, 2023
antazoey
changed the title
fix: show source traceback when can't find dev message [APE-1335]
fix: more source traceback improvements [APE-1335]
Aug 29, 2023
Please help me merge :< |
dtdang
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This helps in the case when a transaction fails before a dev message and a user gets confuses as like ape is not actually finding the dev message when actually the line it is failing on earlier. This PR shows the source traceback in that case.
before it was this:
now it looks like this:
How I did it
How to verify it
Checklist