fix(unreleased): bug where evm-chains ecosystems overrode plugin ecosystems. #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Nov 21, 2024
| assert actual.name == "moonbeam" | ||
|
|
||
|
|
||
| def test_getattr_plugin_ecosystem_same_name_as_evm_chains(mocker, networks): |
There was a problem hiding this comment.
this is the test for the bug
bitwise-constructs
previously approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Thanks @bitwise-constructs for finding this before we released.
Fixed bug where evm-chains ecosystems were overriding ecosystems from plugins.
How I did it
change order of dict comprenhension
How to verify it
have plugin installed
make sure uses plugin
Checklist