Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto patch workspace folder without space #1107

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

khorshuheng
Copy link
Collaborator

In older version of AppFlowy, there's no concept of space. As a result, they can't be rendered in AppFlowy Web easily. In this PR, we will attempt to fix such case based on the following logic:

  1. If the view that corresponds to the workspace has children, but none of the children are a valid space, or there is no children at all, then create a new space.
  2. If there is at least one children, then all the children directly under the workspace view should be moved under the newly created space.

@khorshuheng khorshuheng requested a review from appflowy December 31, 2024 08:57
src/biz/collab/ops.rs Outdated Show resolved Hide resolved
src/biz/collab/ops.rs Outdated Show resolved Hide resolved
@khorshuheng khorshuheng force-pushed the patch-old-workspace-folder branch 2 times, most recently from 15e3bb9 to c11eae6 Compare January 2, 2025 09:42
@khorshuheng khorshuheng marked this pull request as draft January 2, 2025 10:28
@khorshuheng khorshuheng force-pushed the patch-old-workspace-folder branch 4 times, most recently from a3822cc to 913649e Compare January 2, 2025 16:08
@khorshuheng khorshuheng marked this pull request as ready for review January 2, 2025 16:43
@khorshuheng
Copy link
Collaborator Author

Depends on AppFlowy-IO/AppFlowy-Collab#362 . Once the PR is merged i will update AppFlowy-Collab version to use the commit on the main branch instead of the PR branch.

@khorshuheng khorshuheng force-pushed the patch-old-workspace-folder branch from 913649e to 07b21e5 Compare January 3, 2025 07:45
@appflowy appflowy merged commit a61a5c5 into main Jan 3, 2025
10 of 12 checks passed
@appflowy appflowy deleted the patch-old-workspace-folder branch January 3, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants