Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/datetime pretty serde #350

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Feat/datetime pretty serde #350

merged 6 commits into from
Dec 16, 2024

Conversation

speed2exe
Copy link
Contributor

@speed2exe speed2exe commented Dec 11, 2024 •
edited
Loading

  • Attempts to use system timezone for Datetime field type options, default to Etc/UTC
  • Add pretty format field for DateTime type

@speed2exe speed2exe force-pushed the feat/datetime-pretty-serde branch from 198bae3 to 3b36a2d Compare December 11, 2024 13:03
@speed2exe speed2exe marked this pull request as ready for review December 11, 2024 13:17
richardshiue
richardshiue approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@richardshiue richardshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from what clippy said, LGTM!

@speed2exe speed2exe force-pushed the feat/datetime-pretty-serde branch from 909ba55 to 26e4a3b Compare December 11, 2024 13:59
@appflowy appflowy merged commit 26bfffb into main Dec 16, 2024
6 checks passed
@appflowy appflowy deleted the feat/datetime-pretty-serde branch December 16, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardshiue richardshiue richardshiue approved these changes

@appflowy appflowy Awaiting requested review from appflowy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@speed2exe @richardshiue @appflowy