Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static desktop-file-validate and zsyncmake #47

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Static desktop-file-validate and zsyncmake #47

wants to merge 14 commits into from

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented May 9, 2024 •
edited
Loading

Build static desktop-file-validate and zsyncmake similar to what we are already doing for mksquashfs.

Closes #9

@probonopd probonopd marked this pull request as draft May 9, 2024 08:19
@probonopd
Copy link
Member Author 

$ ./appimagetool-x86_64.AppImage --appimage-extract
$ file squashfs-root/usr/bin/desktop-file-validate
squashfs-root/usr/bin/desktop-file-validate: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, BuildID[sha1]=..., stripped

@probonopd probonopd marked this pull request as ready for review May 9, 2024 08:53
@probonopd probonopd changed the title Add install-static-desktop-file-validate.sh Static desktop-file-validate and zsyncmake May 9, 2024
@Samueru-sama
Copy link
Contributor

Please merge this. I'm building appimages on alpine and they don't have zsync on their repo.

Btw @probonopd I tried to use your static zsyncmake and it isn't working, even though appimagetool says that everything went right with zsyncmake no .zsync file ever gets made.

@probonopd
Copy link
Member Author

@TheAssassin ready for merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAssassin TheAssassin TheAssassin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle static versions of desktop-file-validate and zsyncmake
3 participants
@probonopd @Samueru-sama @TheAssassin