Fix unintentional test case id overwriting

ApplauseOSS · Sep 26, 2023 · 403eabe · 403eabe
1 parent ac0a7d9
commit 403eabe
Show file tree

Hide file tree

Showing 10 changed files with 190 additions and 43 deletions.
diff --git a/dist/index.cjs b/dist/index.cjs
diff --git a/dist/index.cjs.map b/dist/index.cjs.map
diff --git a/dist/index.d.ts b/dist/index.d.ts
diff --git a/dist/index.min.js b/dist/index.min.js
diff --git a/dist/index.min.js.map b/dist/index.min.js.map
diff --git a/dist/index.mjs b/dist/index.mjs
diff --git a/dist/index.mjs.map b/dist/index.mjs.map
diff --git a/package.json b/package.json
@@ -26,8 +26,8 @@
   },
   "scripts": {
     "clean": "rm -rf ./dist/",
-    "lint": "eslint ./src/ ./test/ --fix",
-    "lint-verify": "eslint ./src/ ./test/",
+    "lint": "eslint ./src/ --fix",
+    "lint-verify": "eslint ./src/",
     "build": "rollup -c --bundleConfigAsCjs",
     "test": "yarn jest",
     "publish-verify": "npm publish --dry-run",

diff --git a/src/reporter.ts b/src/reporter.ts
@@ -76,7 +76,7 @@ export class ApplauseReporter {
   }
 }
 
-class RunInitializer {
+export class RunInitializer {
   constructor(private autoApi: AutoApi) {}
 
   async initializeRun(tests?: string[]): Promise<RunReporter> {
@@ -97,7 +97,7 @@ class RunInitializer {
   }
 }
 
-class RunReporter {
+export class RunReporter {
   private readonly TEST_RAIL_CASE_ID_PREFIX: string = 'TestRail-';
   private readonly APPLAUSE_CASE_ID_PREFIX: string = 'Applause-';
 
@@ -124,7 +124,9 @@ class RunReporter {
 
         testRunId: this.testRunId,
         // If the additional params provides either test case id, it will override the parsed value we set above
-        ...params,
+        ...Object.fromEntries(
+          Object.entries(params || {}).filter(([_, v]) => v !== undefined)
+        ),
       })
       .then(res => {
         return res.data.testResultId;