Skip to content

Commit

Permalink
Merge pull request #30 from bobdenotter/main
Browse files Browse the repository at this point in the history
Minor cleanup. Most notably: More robust initialisation of SEO snippet
  • Loading branch information
Fredxd authored Dec 6, 2022
2 parents 4b05b3e + 1de0dae commit 9c1b356
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
1 change: 0 additions & 1 deletion assets/seo/seo.css
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
margin-left: 2px;
vertical-align: middle;
border-top: 4px dashed;
border-top: 4px solid\9;
border-right: 4px solid transparent;
border-left: 4px solid transparent;
}
Expand Down
3 changes: 1 addition & 2 deletions assets/seo/seo.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ class SeoSnippet {
}
}


window.addEventListener("DOMContentLoaded", (event) => {
document.addEventListener("DOMContentLoaded", (event) => {
const seoSnippet = document.querySelector('.seo_snippet');
if (seoSnippet) {
new SeoSnippet(seoSnippet);
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "appolodev/bolt-seo",
"description": "Bolt 4 / 5 - Seo extension",
"description": "Bolt 5 - Seo extension",
"type": "bolt-extension",
"license": "MIT",
"authors": [
Expand All @@ -11,10 +11,10 @@
],
"require": {
"php": ">=7.1.3",
"twig/twig": "^2.12 | ^3.0"
"twig/twig": "^3.0"
},
"require-dev": {
"bolt/core": "^4.0.0",
"bolt/core": "^5.1",
"symplify/easy-coding-standard": "^8.1",
"phpstan/phpstan": "^0.12.32",
"phpstan/phpstan-symfony": "^0.12.6",
Expand Down
2 changes: 0 additions & 2 deletions templates/injector.html.twig
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<script src="{{ asset('assets/seo/seo.js', 'public') }}"></script>
<link rel="stylesheet" href="{{ asset('assets/seo/seo.css', 'public') }}">

{# {% set config = geolocation_settings() | geolocation_decode_json %} #}

0 comments on commit 9c1b356

Please sign in to comment.