Remove :client-events and :transcoder, working directly with CompletableFutures.
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pletableFuture`s.
### Removed
* Remove the `funcool/promesa` dependency.
* This doesn't affect the return values, they remain `java.util.concurrent.CompletableFuture` as before.
* This reduces the libraries dependencies without sacrificing its functionality.
* Remove the `:client-events` from the options map per client and per operation.
The return values are `java.util.concurrent.CompletableFuture`, and the client is feel to compose additional
functionally on top of these futures.
* The previous `on-success` can be achieved with `CompletableFuture.thenApply` or `CompletableFuture.thenCompose`.
* The previous `on-failure` can be achieved with `CompletableFuture.exceptionally`
or `CompletableFuture.exceptionallyCompose`.
* Remove the `:transcoder` from the options map per client and per operation.
* Mapping the response can be achieved with `CompletableFuture.thenApply` or `CompletableFuture.thenCompose`.
* To map the request's payload, supply a different payload.
* Remove the `advanced-async-hooks.md`.
### Changed
* Update the [README.md](README.md) and the [tutorial.md](doc/tutorial.md) to reflect the above changes.
* Bump `clj-kondo`: `2022.04.25` -> `2023.07.13`.
* Move `batch-record->map` from `aerospike-clj.client` to `aerospike-clj.aerospike-record`.
* All async continuation functions are now reified and assigned as a `def` at compile-time.
* This should reduce the number of allocations due to the removal of `(p/then' (fn [...))`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Removed
funcool/promesadependency.java.util.concurrent.CompletableFutureas before.:client-eventsfrom the options map per client and per operation. The return values arejava.util.concurrent.CompletableFuture, and the client is feel to compose additional functionally on top of these futures.on-successcan be achieved withCompletableFuture.thenApplyorCompletableFuture.thenCompose.on-failurecan be achieved withCompletableFuture.exceptionallyorCompletableFuture.exceptionallyCompose.:transcoderfrom the options map per client and per operation.CompletableFuture.thenApplyorCompletableFuture.thenCompose.advanced-async-hooks.md.Changed
clj-kondo:2022.04.25->2023.07.13.batch-record->mapfromaerospike-clj.clienttoaerospike-clj.aerospike-record.defat compile-time.(p/then' (fn [...)).