allows consumer to create customised types.Addr compatible types #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
changed the title
Jorropo
force-pushed
the
friendlierAddr
branch
2 times, most recently
from
6184020 to
144af57
Compare
This is needed to make https://github.com/Jorropo/go-pin-argente work. I have to return a precise [<ip>]:1 format in my net.Addr.String method (that because quic-go REALLY wants to do SNI and I cannot just give it the public key I want to use). (don't look at the :1 too much, it's just to make the SNI IP parser happy, I told it all connections happen on port 1 even tho no such thing exists) However making my custom address type broke ironwood, this patch allows my custom address type to convert itself into ironwood friendly form.
|
What my implementation of such type looks like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to make https://github.com/Jorropo/go-pin-argente work.
I have to return a precise
[<ip>]:1format in myaddr.Stringmethod (that becausequic-goREALLY wants to do SNI and I cannot just give it the public key I want to use). (don't look at the:1too much, it's just to make the SNI IP parser happy, I told it all connections happen on port 1 even tho no such thing exists)However making my custom address type broke ironwood, this patch allows my custom address type to convert itself into ironwood friendly form.