ConigInitialParams: Mot thrst calc changes as requested by Xfacta #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower accel filter value is what we’ve been using for quite some time now due to Leonard Halls recommendation, and the initial parameters is the best way to get this into new builds without changing the default value or affecting upgrades of existing copters. Any other method will put extra work load on Randy.
The slightly different thrust expo calculation is derived from collected data and some experimentation. The biggest change is very large prop sizes will be limited to around 0.80 thrust expo instead of going unrealistically high. This does also give slightly lower thrust expo values for smaller props, but still fits with flight data.