CurrentState: add individual SRate variables #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the SRate for Roll/Pitch/Yaw to be displayed simultaneously, rather than needing to set GCS_PID_MASK to one axis at a time. This is useful since tuning one axis may trigger an oscillation in another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to set GCS_PID_MASK to 7 and display SRate for roll/pitch/yaw simultanously. During tuning last week, I wanted to be able to display SRate for roll and pitch simultaneously while I adjusted some filters and gains in flight.
I could expand this to track every PID variable per axis, but it would be messy, and this is all I need immediately.