AP_Scripting: only open the scripts directory on filesystems that support it

[andyp1per]

No description provided.

[IamPete1]

If we make this change I think we also need to narrow the scope of the error here:

ardupilot/libraries/AP_Scripting/AP_Scripting_config.h

Line 11 in 868a650

#if !AP_FILESYSTEM_FILE_READING_ENABLED

It should be !AP_FILESYSTEM_FILE_WRITING_ENABLED && !defined(HAL_HAVE_AP_ROMFS_EMBEDDED_LUA)

[andyp1per]

If we make this change I think we also need to narrow the scope of the error here:

ardupilot/libraries/AP_Scripting/AP_Scripting_config.h

Line 11 in 868a650

#if !AP_FILESYSTEM_FILE_READING_ENABLED

It should be !AP_FILESYSTEM_FILE_WRITING_ENABLED && !defined(HAL_HAVE_AP_ROMFS_EMBEDDED_LUA)

I'm not sure HAL_HAVE_AP_ROMFS_EMBEDDED_LUA needs to exist. We already have:

#define AP_FILESYSTEM_FILE_READING_ENABLED (AP_FILESYSTEM_FILE_WRITING_ENABLED || AP_FILESYSTEM_ROMFS_ENABLED)

So I think we could actually leave this and simply change HAL_HAVE_AP_ROMFS_EMBEDDED_LUA to AP_FILESYSTEM_ROMFS_ENABLED

[peterbarker]

So I think we could actually leave this and simply change HAL_HAVE_AP_ROMFS_EMBEDDED_LUA to AP_FILESYSTEM_ROMFS_ENABLED

Someone may not want to embed LUA scripts but still want to have ROMFS (e.g. defaults.parm files)

[peterbarker]

You don't actually state what the bug is here.

I'm guessing that it's the fact it emits a warning, "Lua: open directory (%s) failed" on boards that can't opendir? Which boards/filesystems are they, BTW?

[andyp1per]

I'm guessing that it's the fact it emits a warning, "Lua: open directory (%s) failed" on boards that can't opendir? Which boards/filesystems are they, BTW?

Yes that's it - MambaH743v4 was the one I was testing

[peterbarker]

I've created this alternative PR which takes a different approach: #28012

[tridge]

@andyp1per we have merged the alternative from @peterbarker - it's less likely to have unintended side effects