Add arming check that all defaults in defaults files are used #27782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/defaults-must-be-used
branch
2 times, most recently
from
e3b859e
to
6fef5e8
Compare
peterbarker
force-pushed
the
pr/defaults-must-be-used
branch
from
6fef5e8
to
fd63832
Compare
this will help with firmware migration where users may have old parameters in defaults files and not realising they aren't having an effect
this will help with firmware migration where users may have old parameters in defaults files and not realising they aren't having an effect
peterbarker
force-pushed
the
pr/defaults-must-be-used
branch
from
fd63832
to
67cce30
Compare
|
That CubeOrange problem shows we can't really do this. |
|
What was the problem here exactly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instant problem on CubeOrange: