Skip to content

Commit

Permalink
Merge bitcoindevkit#1623: fix!(wallet): ChangeSet should not be non…
Browse files Browse the repository at this point in the history
…-exhaustive

d7dfe38 fix!(wallet): `ChangeSet` should not be non-exhaustive (志宇)

Pull request description:

  Closes bitcoindevkit#1591

  ### Description

  As stated in bitcoindevkit#1591, it is handy to know when new values are added to `ChangeSet`.

  ### Notes to the reviewers

  ~

  ### Changelog notice

  * Remove `#[non_exhaustive]` attribute from `wallet::ChangeSet`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  oleonardolima:
    utACK d7dfe38
  ValuedMammal:
    ACK d7dfe38

Tree-SHA512: 2856d9af625ee788c5ddec0a51dace26a1cb1b57b327ffb8439fe8a45888cdf2ecaeac8d2c777620f83b66d211bac4d17fea3d1143800127316ba475b5064b23
  • Loading branch information
ValuedMammal committed Sep 28, 2024
2 parents 9e47b64 + d7dfe38 commit 4942cc6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion crates/wallet/src/wallet/changeset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ type IndexedTxGraphChangeSet =

/// A changeset for [`Wallet`](crate::Wallet).
#[derive(Default, Debug, Clone, PartialEq, serde::Deserialize, serde::Serialize)]
#[non_exhaustive]
pub struct ChangeSet {
/// Descriptor for recipient addresses.
pub descriptor: Option<Descriptor<DescriptorPublicKey>>,
Expand Down

0 comments on commit 4942cc6

Please sign in to comment.