Bump Serilog.Sinks.PeriodicBatching from 3.1.0 to 4.0.0 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
.NET
|
dependabot
bot
force-pushed
the
dependabot/nuget/Serilog.Sinks.PeriodicBatching-4.0.0
branch
from
a1f6471 to
39249f3
Compare
dependabot
bot
force-pushed
the
dependabot/nuget/Serilog.Sinks.PeriodicBatching-4.0.0
branch
2 times, most recently
from
e7707fb to
89c0d96
Compare
|
@sungam3r Very strange... One test with the batch sink is failing. When I increase the timeout beyond the 2 second default period, the test finishes successful. It would appear that the EagerlyEmitFirstEvent setting is ignored. |
|
@nblumhardt can help with changes in batching sink. |
|
I create an issue at the repo |
|
@dependabot rebase |
Bumps [Serilog.Sinks.PeriodicBatching](https://github.com/serilog/serilog-sinks-periodicbatching) from 3.1.0 to 4.0.0. - [Release notes](https://github.com/serilog/serilog-sinks-periodicbatching/releases) - [Commits](serilog/serilog-sinks-periodicbatching@v3.1.0...v4.0.0) --- updated-dependencies: - dependency-name: Serilog.Sinks.PeriodicBatching dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/nuget/Serilog.Sinks.PeriodicBatching-4.0.0
branch
from
89c0d96 to
5d8123c
Compare
ArieGato
reviewed
Mar 15, 2024
ArieGato
approved these changes
Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
- Coverage 96.70% 96.28% -0.42%
==========================================
Files 8 8
Lines 485 485
Branches 45 45
==========================================
- Hits 469 467 -2
- Misses 7 9 +2
Partials 9 9 ☔ View full report in Codecov by Sentry. |
ArieGato
approved these changes
Mar 15, 2024
dependabot
bot
deleted the
dependabot/nuget/Serilog.Sinks.PeriodicBatching-4.0.0
branch
|
Should be noted in breaking changes in changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Serilog.Sinks.PeriodicBatching from 3.1.0 to 4.0.0.
Release notes
Sourced from Serilog.Sinks.PeriodicBatching's releases.
Commits
b3821e5Merge pull request #68 from serilog/dev773fdb6Merge pull request #67 from nblumhardt/suppress-execution-context-flow010449cPrevent capturing of the sink-creation-time ExecutionContext by the batching ...180f5e7Publishing key6455380Merge pull request #66 from nblumhardt/modernize-again83f9133Factor out SelfLog calls and improve formatting7983a13Review feedback535a290Comment explaining why the period-bounded batch filling loop is outside the t...9f2cea4Inherit docs for IDisposable.Dispose()81b23faDon't allow the run loop to be canceled before execution, since it violates t...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)