Bug fix july 2024

[SuperFola]

Description

Addressing a bunch of bugs reported by the fuzzers. Still need to add documentation about fuzzing arkscript on the readme & website.

Closes #260

Checklist

• I have read the Contributor guide
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation if needed
• I have added tests that prove my fix/feature is working
• New and existing tests pass locally with my changes

[github-actions]

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename	Start line:end line	Function name	Parameters	NLOC	CCN
src/arkreactor/VM/VM.cpp	258:1079	Ark::VM::safeRun	2	661	170
src/arkreactor/Compiler/Macros/Processor.cpp	243:495	Ark::internal::MacroProcessor::evaluate	2	212	76
src/arkreactor/Compiler/Compiler.cpp	557:686	Ark::Compiler::handleCalls	5	101	35
src/arkreactor/Compiler/Compiler.cpp	269:360	Ark::Compiler::compileExpression	5	75	25
src/arkreactor/Compiler/Macros/Processor.cpp	125:195	Ark::internal::MacroProcessor::processNode	2	54	21
src/arkreactor/Compiler/AST/Parser.cpp	269:396	Ark::internal::Parser::import_	0	103	21
src/arkreactor/Compiler/Macros/Executors/Function.cpp	12:86	Ark::internal::FunctionExecutor::applyMacro	1	60	18
src/arkreactor/Compiler/Macros/Processor.cpp	54:99	Ark::internal::MacroProcessor::registerMacro	1	41	16
src/arkreactor/Exceptions.cpp	79:125	Ark::Diagnostics::makeContext	5	34	16
src/arkscript/Formatter.cpp	153:206	Formatter::format	3	51	15
src/arkreactor/Exceptions.cpp	128:137	Ark::Diagnostics::helper	8	9	3

Report about files you didn't modify in this PR

Filename	Start line:end line	Function name	Parameters	NLOC	CCN
src/arkreactor/Compiler/BytecodeReader.cpp	199:488	Ark::BytecodeReader::display	4	258	120
include/Ark/Compiler/AST/Parser.hpp	84:173	Ark::internal::ARK_APIParser::string	0	87	32
src/arkscript/main.cpp	17:300	main	2	246	30
src/arkscript/JsonCompiler.cpp	23:188	JsonCompiler::_compile	1	139	23
src/arkreactor/Compiler/AST/Node.cpp	209:279	Ark::internal::Node::debugPrint	1	61	23
include/utf8.hpp	138:184	utf8::isValid	1	44	21
src/arkreactor/VM/Value.cpp	77:135	Ark::Value::toString	1	46	17
src/arkreactor/Compiler/AST/Node.cpp	143:207	Ark::internal::Node::repr	0	56	17
include/Ark/Compiler/AST/Predicates.hpp	162:186	Ark::internal::IsSymbol::operator ( )	1	24	16
src/arkreactor/TypeChecker.cpp	27:78	Ark::types::displayContract	2	45	15
include/Ark/Exceptions.hpp	92:101	Ark::CodeError::CodeError	6	10	1

---

CppCheck report

Filename	Line	Type	Description
include/Ark/Compiler/AST/utf8_char.hpp	28	style	Local variable 'codepoint' shadows outer function
src/arkreactor/Compiler/AST/BaseParser.cpp	316	style	Consider using std::any_of algorithm instead of a raw loop.
src/arkreactor/Compiler/AST/BaseParser.cpp	356	style	Consider using std::any_of algorithm instead of a raw loop.
src/arkreactor/Compiler/AST/Parser.cpp	388	error	Uninitialized variable: import_data.with_prefix
include/Ark/Compiler/Macros/Executor.hpp	64	performance	Function parameter 'origin' should be passed by const reference.
include/Ark/Compiler/Macros/Processor.hpp	162	performance	Function parameter 'origin' should be passed by const reference.
src/arkreactor/Compiler/Compiler.cpp	140	style	Consider using std::copy algorithm instead of a raw loop.
src/arkreactor/Compiler/Compiler.cpp	160	style	Consider using std::copy algorithm instead of a raw loop.
src/arkreactor/Compiler/Compiler.cpp	167	style	Consider using std::copy algorithm instead of a raw loop.
src/arkreactor/Compiler/Macros/Executor.cpp	12	performance	Function parameter 'origin' should be passed by const reference.
src/arkreactor/Compiler/Macros/Executors/Function.cpp	14	style	The scope of the variable 'first' can be reduced.
src/arkreactor/Compiler/Macros/Processor.cpp	236	performance	Function parameter 'origin' should be passed by const reference.
src/arkreactor/VM/Future.cpp	10	performance	Variable 'm_value' is assigned in constructor body. Consider performing initialization in initialization list.
src/arkreactor/VM/VM.cpp	555	style	Consider using std::copy algorithm instead of a raw loop.
src/arkreactor/VM/VM.cpp	605	style	Consider using std::copy algorithm instead of a raw loop.

Report files about files you didn't modify in this PR

Filename	Line	Type	Description
include/Ark/TypeChecker.hpp	69	performance	Function parameter 'name' should be passed by const reference.
include/Ark/TypeChecker.hpp	73	performance	Function parameter 'name' should be passed by const reference.
src/arkreactor/Builtins/IO.cpp	24	style	Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp	43	style	Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp	192	style	Consider using std::transform algorithm instead of a raw loop.
include/Ark/Compiler/AST/Predicates.hpp	117	performance	Function parameter 'c' should be passed by const reference.
include/Ark/Compiler/AST/Optimizer.hpp	63	style	Unused private function: 'Optimizer::throwOptimizerError'
include/Ark/Compiler/AST/Parser.hpp	177	style	Local variable 'symbol' shadows outer function
src/arkreactor/Compiler/ImportSolver.cpp	148	style	Consider using std::transform algorithm instead of a raw loop.
src/arkreactor/TypeChecker.cpp	80	performance	Function parameter 'funcname' should be passed by const reference.
src/arkreactor/VM/Scope.cpp	51	style	Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp	61	style	Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp	71	style	Variable 'id' is not assigned a value.
src/arkreactor/VM/State.cpp	129	style	Consider using std::transform algorithm instead of a raw loop.
src/arkscript/main.cpp	141	style	Consider using std::copy algorithm instead of a raw loop.
src/arkscript/main.cpp	148	style	Consider using std::copy algorithm instead of a raw loop.

[github-actions]

Fuzzing report

/usr/local/bin/afl-whatsup status check tool for afl-fuzz by Michal Zalewski

Summary stats

    Fuzzers alive : 0
   Dead or remote : 1 (included in stats)
   Total run time : 5 minutes, 0 seconds
      Total execs : 48 thousands
 Cumulative speed : 162 execs/sec
    Pending items : 114 faves, 852 total
 Coverage reached : 10.88%
    Crashes saved : 0
      Hangs saved : 0

Cycles without finds : 0
Time without finds : 0

[+] Captured 27112 tuples (map size 165351, highest value 255, total values 194403894) in '/dev/null'.
[+] A coverage of 27112 edges were achieved out of 165376 existing (16.39%) with 861 input files.