Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/macro processor #501

Merged
merged 7 commits into from
Nov 23, 2024
Merged

Refactor/macro processor #501

merged 7 commits into from
Nov 23, 2024

Conversation

SuperFola
Copy link
Member

Description

Refactors the Macro processor to make it easier to work with.

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes

Copy link

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/Compiler/Macros/Processor.cpp 207:536 Ark::internal::MacroProcessor::evaluate 3 308 122
src/arkreactor/Compiler/Compiler.cpp 418:580 Ark::internal::Compiler::handleCalls 5 131 39
src/arkreactor/Compiler/Compiler.cpp 120:215 Ark::internal::Compiler::compileExpression 5 79 25
src/arkreactor/Compiler/AST/Node.cpp 207:273 Ark::internal::Node::debugPrint 1 58 23
src/arkreactor/Compiler/Macros/Processor.cpp 100:171 Ark::internal::MacroProcessor::processNode 2 53 20
src/arkreactor/Compiler/AST/Node.cpp 141:205 Ark::internal::Node::repr 0 56 17
src/arkreactor/Compiler/Macros/Executors/Function.cpp 16:88 Ark::internal::FunctionExecutor::applyMacro 2 55 17
src/arkreactor/Compiler/Macros/Processor.cpp 618:656 Ark::internal::MacroProcessor::isConstEval 1 34 15
Report about files you didn't modify in this PR
Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/VM/VM.cpp 320:1270 Ark::VM::safeRun 3 771 161
src/arkreactor/Compiler/BytecodeReader.cpp 197:447 Ark::BytecodeReader::display 4 215 76
src/arkscript/REPL/Repl.cpp 17:229 Ark::Repl::Repl 1 180 35
src/arkscript/JsonCompiler.cpp 26:248 JsonCompiler::_compile 1 191 35
include/Ark/Compiler/AST/Parser.hpp 105:194 Ark::internal::ARK_APIParser::string 0 87 32
src/arkscript/main.cpp 17:336 main 2 276 30
src/arkreactor/Compiler/IntermediateRepresentation/IROptimizer.cpp 120:149 Ark::internal::IROptimizer::compactEntities 3 20 28
src/arkreactor/Compiler/NameResolutionPass.cpp 178:277 Ark::internal::NameResolutionPass::visitKeyword 2 90 25
src/arkreactor/Compiler/AST/Parser.cpp 272:403 Ark::internal::Parser::import_ 0 106 23
include/utf8.hpp 138:184 utf8::isValid 1 44 21
src/arkreactor/Compiler/NameResolutionPass.cpp 114:176 Ark::internal::NameResolutionPass::visit 1 53 18
src/arkreactor/VM/Value.cpp 67:125 Ark::Value::toString 1 46 17
include/Ark/Compiler/AST/Predicates.hpp 132:156 Ark::internal::IsSymbol::operator ( ) 1 24 16
src/arkreactor/Compiler/IntermediateRepresentation/IROptimizer.cpp 87:118 Ark::internal::IROptimizer::compactEntities 2 18 16
src/arkscript/Formatter.cpp 168:221 Formatter::format 3 51 15
src/arkreactor/TypeChecker.cpp 28:85 Ark::types::displayContract 2 51 15
src/arkreactor/Exceptions.cpp 86:130 Ark::Diagnostics::makeContext 6 35 15
src/arkreactor/Exceptions.cpp 133:146 Ark::Diagnostics::helper 9 12 4
include/Ark/Exceptions.hpp 92:101 Ark::CodeError::CodeError 6 10 1

CppCheck report

Filename Line Type Description
src/arkreactor/Compiler/Macros/Processor.cpp 67 warning Assert statement calls a function which may have desired side effects: 'list'.
Report files about files you didn't modify in this PR
Filename Line Type Description
src/arkreactor/Builtins/IO.cpp 24 style Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp 43 style Parameter 'n' can be declared with const
include/Ark/Compiler/AST/Optimizer.hpp 64 style Unused private function: 'Optimizer::throwOptimizerError'
include/Ark/Compiler/AST/Optimizer.hpp 70 style Unused private function: 'Optimizer::removeUnused'
src/arkreactor/Compiler/AST/Parser.cpp 395 error Uninitialized variable: import_data.with_prefix
src/arkreactor/Compiler/BytecodeReader.cpp 332 style struct member 'Arg::arg' is never used.
src/arkreactor/Compiler/IntermediateRepresentation/IROptimizer.cpp 11 style struct member 'EntityWithOffset::offset' is never used.
src/arkreactor/VM/Scope.cpp 51 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 61 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 71 style Variable 'id' is not assigned a value.
src/arkreactor/VM/VM.cpp 434 style Statements following return, break, continue, goto or throw will never be executed.
src/arkreactor/VM/VM.cpp 358 error syntax error
src/arkscript/JsonCompiler.cpp 171 style Consider using std::accumulate algorithm instead of a raw loop.
src/arkscript/JsonCompiler.cpp 178 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 24 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 26 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 28 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 30 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 36 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 38 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 47 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/main.cpp 84 information Unmatched suppression: constStatement

@coveralls
Copy link

Coverage Status

coverage: 77.19% (-0.1%) from 77.285%
when pulling ec12b52 on refactor/macro-processor
into cc6fa5b on dev.

Copy link

Fuzzing report

/usr/local/bin/afl-whatsup status check tool for afl-fuzz by Michal Zalewski

Summary stats

    Fuzzers alive : 0
   Dead or remote : 1 (included in stats)
   Total run time : 5 minutes, 0 seconds
      Total execs : 39 thousands
 Cumulative speed : 133 execs/sec
    Pending items : 94 faves, 830 total
 Coverage reached : 9.85%
    Crashes saved : 0
      Hangs saved : 0

Cycles without finds : 0
Time without finds : 0

[+] Captured 33567 tuples (map size 185843, highest value 255, total values 267315574) in '/dev/null'.
[+] A coverage of 33567 edges were achieved out of 185856 existing (18.06%) with 839 input files.

@SuperFola SuperFola merged commit 66b5650 into dev Nov 23, 2024
25 of 26 checks passed
@SuperFola SuperFola deleted the refactor/macro-processor branch November 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants