Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the new imports syntax #502

Merged
merged 17 commits into from
Dec 4, 2024
Merged

Implementing the new imports syntax #502

merged 17 commits into from
Dec 4, 2024

Conversation

SuperFola
Copy link
Member

@SuperFola SuperFola commented Dec 3, 2024

Description

This PR finally implements the new import syntax, along with tests related to name resolution. Those might have to be rewritten to be able to check the AST before and after name resolution.

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes

Copy link

github-actions bot commented Dec 3, 2024

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/VM/VM.cpp 320:1285 Ark::VM::safeRun 3 786 162
src/arkreactor/Compiler/Macros/Processor.cpp 219:548 Ark::internal::MacroProcessor::evaluate 3 308 122
src/arkreactor/Compiler/Compiler.cpp 421:583 Ark::internal::Compiler::handleCalls 5 131 39
src/arkreactor/Compiler/NameResolution/NameResolutionPass.cpp 160:258 Ark::internal::NameResolutionPass::visitKeyword 3 83 30
src/arkreactor/Compiler/Macros/Processor.cpp 100:183 Ark::internal::MacroProcessor::processNode 3 61 26
src/arkreactor/Compiler/Compiler.cpp 120:218 Ark::internal::Compiler::compileExpression 5 81 26
src/arkreactor/Compiler/AST/Node.cpp 233:307 Ark::internal::Node::debugPrint 1 65 24
src/arkreactor/Compiler/AST/Parser.cpp 272:404 Ark::internal::Parser::import_ 0 107 23
src/arkreactor/Compiler/NameResolution/NameResolutionPass.cpp 55:158 Ark::internal::NameResolutionPass::visit 2 84 23
src/arkreactor/Compiler/AST/Node.cpp 160:231 Ark::internal::Node::repr 0 59 18
src/arkscript/Formatter.cpp 168:224 Formatter::format 3 53 16
src/arkreactor/Compiler/Macros/Processor.cpp 630:669 Ark::internal::MacroProcessor::isConstEval 1 35 16
src/arkreactor/Exceptions.cpp 86:130 Ark::Diagnostics::makeContext 6 35 15
src/arkreactor/Exceptions.cpp 133:146 Ark::Diagnostics::helper 9 12 4
Report about files you didn't modify in this PR
Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/Compiler/BytecodeReader.cpp 197:447 Ark::BytecodeReader::display 4 215 76
src/arkscript/REPL/Repl.cpp 17:229 Ark::Repl::Repl 1 180 35
src/arkscript/JsonCompiler.cpp 26:248 JsonCompiler::_compile 1 191 35
include/Ark/Compiler/AST/Parser.hpp 105:194 Ark::internal::ARK_APIParser::string 0 87 32
src/arkscript/main.cpp 17:336 main 2 276 30
src/arkreactor/Compiler/IntermediateRepresentation/IROptimizer.cpp 120:149 Ark::internal::IROptimizer::compactEntities 3 20 28
include/utf8.hpp 138:184 utf8::isValid 1 44 21
src/arkreactor/VM/Value.cpp 67:125 Ark::Value::toString 1 46 17
src/arkreactor/Compiler/Macros/Executors/Function.cpp 16:88 Ark::internal::FunctionExecutor::applyMacro 2 55 17
include/Ark/Compiler/AST/Predicates.hpp 132:156 Ark::internal::IsSymbol::operator ( ) 1 24 16
src/arkreactor/Compiler/IntermediateRepresentation/IROptimizer.cpp 87:118 Ark::internal::IROptimizer::compactEntities 2 18 16
src/arkreactor/TypeChecker.cpp 28:85 Ark::types::displayContract 2 51 15
include/Ark/Exceptions.hpp 92:101 Ark::CodeError::CodeError 6 10 1

CppCheck report

Filename Line Type Description
src/arkreactor/Compiler/AST/Node.cpp 33 performance Function parameter 'namespace_' should be passed by const reference.
src/arkreactor/Compiler/AST/Parser.cpp 396 error Uninitialized variables: import_data.with_prefix, import_data.is_glob
src/arkreactor/Compiler/Macros/Processor.cpp 67 warning Assert statement calls a function which may have desired side effects: 'list'.
src/arkreactor/Compiler/NameResolution/NameResolutionPass.cpp 141 style Consider using std::find_if algorithm instead of a raw loop.
src/arkreactor/Compiler/NameResolution/ScopeResolver.cpp 58 style Consider using std::any_of algorithm instead of a raw loop.
src/arkreactor/VM/VM.cpp 434 style Statements following return, break, continue, goto or throw will never be executed.
src/arkreactor/VM/VM.cpp 358 error syntax error
src/arkreactor/VM/Value/Closure.cpp 21 style Parameter 'vm' can be declared with const
src/arkreactor/VM/Value/Closure.cpp 25 style Consider using std::any_of algorithm instead of a raw loop.
Report files about files you didn't modify in this PR
Filename Line Type Description
src/arkreactor/Builtins/IO.cpp 24 style Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp 43 style Parameter 'n' can be declared with const
include/Ark/Compiler/AST/Optimizer.hpp 64 style Unused private function: 'Optimizer::throwOptimizerError'
include/Ark/Compiler/AST/Optimizer.hpp 70 style Unused private function: 'Optimizer::removeUnused'
src/arkreactor/Compiler/BytecodeReader.cpp 332 style struct member 'Arg::arg' is never used.
src/arkreactor/Compiler/IntermediateRepresentation/IROptimizer.cpp 11 style struct member 'EntityWithOffset::offset' is never used.
src/arkreactor/VM/Scope.cpp 51 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 61 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 71 style Variable 'id' is not assigned a value.
src/arkscript/JsonCompiler.cpp 171 style Consider using std::accumulate algorithm instead of a raw loop.
src/arkscript/JsonCompiler.cpp 178 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 24 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 26 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 28 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 30 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 36 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 38 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 47 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/main.cpp 84 information Unmatched suppression: constStatement

@coveralls
Copy link

coveralls commented Dec 3, 2024

Coverage Status

coverage: 77.837% (+0.6%) from 77.19%
when pulling da8f49a on feat/imports
into 66b5650 on dev.

Copy link

github-actions bot commented Dec 4, 2024

Fuzzing report

/usr/local/bin/afl-whatsup status check tool for afl-fuzz by Michal Zalewski

Summary stats

    Fuzzers alive : 0
   Dead or remote : 1 (included in stats)
   Total run time : 5 minutes, 0 seconds
      Total execs : 36 thousands
 Cumulative speed : 122 execs/sec
    Pending items : 102 faves, 849 total
 Coverage reached : 10.03%
    Crashes saved : 6
      Hangs saved : 0

Cycles without finds : 0
Time without finds : 0

[+] Captured 34164 tuples (map size 189464, highest value 255, total values 281395332) in '/dev/null'.
[+] A coverage of 34164 edges were achieved out of 189504 existing (18.03%) with 864 input files.

@SuperFola SuperFola merged commit c424993 into dev Dec 4, 2024
26 checks passed
@SuperFola SuperFola deleted the feat/imports branch December 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants