Use a different approach to check entity for modstorage #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only needs to keep track of players. See comments in CF_ModStorageModule.c near the top.
|
Important note: The wipefile version has been bumped to 129 (1.17 Experimental). If you are on 1.17 Exp and have existing storage, just add an empty |
|
Turns out identity is NULL at a point where I'm checking it, this went unnoticed because it doesn't seem to cause any readily visible problems. I'll try and come up with a fix for this later. |
Player may get booted before the game has had a chance to assign his identity, which will cause his inventory to be persisted immediately, so we need to add him for next load
…tion - ModStorage is now at version 5 (version 4 will be read and converted) - Moved from saving/reading all data as string to handling each data type separately (fixes memory leak in case of read errors) - Fixed unloaded mods array not being resized to correct size if read failed - Optimization: Do not save mods without data
This reverts commit 05733f1.
|
Just as a heads-up, this version of ModStorage is used by Expansion since the 14th by duplicating some of the bits to make it work until CF catches up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only needs to keep track of players. See comments in CF_ModStorageModule.c near the top.