Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the hyperparameter logging when executing
train.py
orevaluate.py
in the following ways, i.e.log_hyperparameters()
:ConfigDict
entries are correctly un-nested (compare thedataset
entry in the W&B run config view, for instance)model._config()
andtaskmodule._config()
at all, because the model parameters are automatically logged by callingself.save_hyperparameters()
in the model and in the future each model should receivetaskmodule_config
as parameter, so that will get logged as well (taskmodule._config()
is currently still logged in some cases for backwards compatibility)key_prefix
, which is"_"
per default, to distinguish them from the model parameters.In addition, with this PR two more parameters are logged:
_best_checkpoint
:os.path.basename(best_ckpt_path)
taken from the checkpoint callback_checkpoint_dir
:dirpath
taken from the checkpoint callbackNote: this requires
pie-modules>=0.9.0