Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature create route panel #89

Merged
merged 39 commits into from
Apr 1, 2020
Merged

Conversation

PabloCanalSuarez
Copy link
Contributor

Issues involved: #81, #69, #70, #71, #86 and #82

UO264850 and others added 30 commits March 18, 2020 18:18
Also added dependencies for date and date picker.
Now, these classes are component-based instead of dumb functions.
Now, at least one track point must be selected in the map to allow the creation of the route.
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #89 into development will decrease coverage by 3.3%.
The diff coverage is 4.15%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development     #89      +/-   ##
==============================================
- Coverage         9.61%   6.31%   -3.31%     
==============================================
  Files               26      38      +12     
  Lines              156     412     +256     
  Branches             2      16      +14     
==============================================
+ Hits                15      26      +11     
- Misses             139     370     +231     
- Partials             2      16      +14
Impacted Files Coverage Δ
src/components/graphic interface/FriendsCard.js 20% <ø> (ø) ⬆️
src/components/services/login/Login.js 10% <ø> (ø) ⬆️
src/entities/User.js 0% <ø> (ø) ⬆️
src/components/containers/Routes.js 50% <ø> (ø) ⬆️
src/entities/Route.js 0% <0%> (ø) ⬆️
src/entities/RouteElement.js 0% <0%> (ø) ⬆️
src/components/graphic interface/NavBar.js 50% <0%> (ø) ⬆️
...components/containers/stepper/dataform/DataForm.js 0% <0%> (ø)
...c/components/containers/stepper/mapform/MapForm.js 0% <0%> (ø)
src/components/map/EditableMap.js 0% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7a7dd...bd8ab77. Read the comment docs.

@PabloCanalSuarez
Copy link
Contributor Author

Please, wait until I fix some Codacy errors

@CarmenVigo
Copy link
Contributor

lgtm

@CarmenVigo CarmenVigo merged commit e125b42 into development Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants